fedpkg

#102 Trailing / on git remotes should be ignored.
Closed: Fixed Opened by lverns.

Closed: Fixed
Reopen Issue

fedkpg sometimes uses the URL of a git remote to determine the name of a module. From the man page:

--module-name MODULE_NAME
                      Override the module name. Otherwise it is discovered
                      from: Git push URL or Git URL (last part of path with
                      .git extension removed) or from name macro in spec
                      file. In that order.

If the git URL ends in a /, e.g git@server:mylib.git/ as opposed to git@server:mylib.git, fedpkg will fail to retrieve the name from it. If the spec file also lacks the name macro, then fedpkg mockbuild may fail in strange ways and the output will be placed in results_ instead of results_mylib.

[Edit: fixed typo]

If the git URL ends in a /, ..., fedpkg will fail to retrieve the name from it.

Playing around with this a bit more, I think that this statement is incorrect. If the git URL ends in a /, fedpkg will still retrieve a name from it, but it will be the empty string.

If the spec file also lacks the name macro...

I'm not sure if that is even possible.

This is actually a bug in rpkg. https://pagure.io/rpkg/issue/192

Metadata Update from @cqi:
- Issue set to the milestone: 1.29

As this problem belongs to rpkg and https://pagure.io/rpkg/issue/192 was already fixed, close this issue.

Metadata Update from @cqi:
- Issue close_status updated to: Fixed
- Issue set to the milestone: None (was: 1.29)
- Issue status updated to: Closed (was: Open)
Metadata
None
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.