PR#159: roles/testing-farm*: handle non json output - fedora-zuul-jobs

fedora-zuul-jobs

#159 roles/testing-farm*: handle non json output

Merged 2 years ago by zuul. Opened 2 years ago by mvadkert.

mvadkert/fedora-zuul-jobs TFT-1553 into master

roles/testing-farm*: handle non json output

Miroslav Vadkerti • 2 years ago

1b0df0c

roles/testing-farm-run-generic-test/tasks/main.yml

file modified

+1 -2

		`@@ -81,8 +81,7 @@`
		`status_code: 200`
		`timeout: 30`
		`register: response`
		`- until: response.json.state == "complete" or`
		`- response.json.state == "error"`
		`+ until: "'json' in response and (response.json.state == 'complete' or response.json.state == 'error')"`
		`retries: 720`
		`delay: 60`
		`ignore_errors: true`

roles/testing-farm-run-test/tasks/main.yml

file modified

+1 -2

		`@@ -61,8 +61,7 @@`
		`status_code: 200`
		`timeout: 30`
		`register: response`
		`- until: response.json.state == "complete" or`
		`- response.json.state == "error"`
		`+ until: "'json' in response and (response.json.state == 'complete' or response.json.state == 'error')"`
		`retries: 720`
		`delay: 60`
		`ignore_errors: true`

mvadkert commented 2 years ago

Obviously it can happen the response is invalid and it
is not a valid json, so add a check to make sure we process
only json output.

Resolves TFT-1553

Signed-off-by: Miroslav Vadkerti mvadkert@redhat.com

mvadkert commented 2 years ago

Tested manually via:

❯ ansible -c localhost -m debug -e '{ "response": { "tutu": { "state": "complete" }}}' -a "msg={{ 'json' in response and (response.json.state == 'complete' or response.json.state == 'error') }}" localhost
localhost | SUCCESS => {
    "msg": false
}

❯ ansible -c localhost -m debug -e '{ "response": { "json": { "state": "complete" }}}' -a "msg={{ 'json' in response and (response.json.state == 'complete' or response.json.state == 'error') }}" localhost
localhost | SUCCESS => {
    "msg": true
}