PR#128: remove rpm-tests job and related playbook - fedora-zuul-jobs

fedora-zuul-jobs

#128 remove rpm-tests job and related playbook

Opened 3 years ago by guyinger. Modified 3 years ago

guyinger/fedora-zuul-jobs cleanup_old_check_sti_jobs into master

remove rpm-tests job and related playbook

ginger • 3 years ago

b5e51e2

playbooks/rpm/rpmtest.yaml

file removed

-20

		`@@ -1,20 +0,0 @@`
		`- ---`
		`- - hosts: all`
		`- roles:`
		`- - repo-setup`
		`- - extra-repos-setup`
		`- - repo-install-rpm`
		`- - run-tests-yml`
		`- pre_tasks:`
		`- - name: Force dnf to ipv4 only`
		`- become: true`
		`- lineinfile:`
		`- path: /etc/dnf/dnf.conf`
		`- insertafter: '^\[main\]'`
		`- line: "ip_resolve=4"`
		`- - name: Install STI system dependencies`
		`- yum:`
		`- name: standard-test-roles`
		`- state: latest`
		`- use_backend: "dnf"`
		`- become: true`

zuul.d/jobs.dhall

file modified

-42

		`@@ -73,44 +73,6 @@`

		`in job`

		`- let createRpmTestJob`
		`- : Branches.Type → Zuul.Job.Type`
		`- = λ(branch : Branches.Type) →`
		`- let getNodesetByBranch =`
		`- λ(branch : Branches.Type) →`
		`- merge`
		`- { Rawhide =`
		`- Nodesets.getName Nodesets.Type.Fedora-Rawhide-VM-Medium`
		`- , F33 = Nodesets.getName Nodesets.Type.Fedora-33-VM-Medium`
		`- , F34 = Nodesets.getName Nodesets.Type.Fedora-34-VM-Medium`
		`- , F35 = Nodesets.getName Nodesets.Type.Fedora-35-VM-Medium`
		`- , Epel8 = Nodesets.getName Nodesets.Type.Centos-8-VM`
		`- }`
		`- branch`
		`-`
		`- let job =`
		`- Zuul.Job::{`
		`- , name = "rpm-test"`
		`- , description = Some`
		`- "Install the built rpms and run STI tests (${Branches.show`
		`- branch} variant)"`
		`- , roles = Some [ { zuul = "zuul-distro-jobs" } ]`
		`- , timeout = Some 18000`
		`- , requires = Some [ "repo" ]`
		`- , run = Some "playbooks/rpm/rpmtest.yaml"`
		`- , post-run = Some [ "playbooks/rpm/rpmtest-fetch-artifacts.yaml" ]`
		`- , branches = Branches.zuulBranch branch`
		`- , nodeset = Some (getNodesetByBranch branch)`
		`- , vars = Some (createJobVars (Branches.kojirepos branch))`
		`- }`
		`-`
		`- let job =`
		`- if Branches.isEpel8 branch`
		`- then job ⫽ { pre-run = Some [ "playbooks/epel8/install.yaml" ] }`
		`- else job`
		`-`
		`- in job`
		`-`
		`let createRpmInspectJob`
		`: Branches.Type → Zuul.Job.Type`
		`= λ(branch : Branches.Type) →`
		`@@ -158,9 +120,6 @@`
		`createRpmInstallTestJob`
		`Branches.all`

		`- let rpm_test_jobs =`
		`- Prelude.List.map Branches.Type Zuul.Job.Type createRpmTestJob Branches.all`
		`-`
		`let rpminspect_jobs =`
		`Prelude.List.map`
		`Branches.Type`
		`@@ -170,7 +129,6 @@`

		`let jobs =`
		`rpm_install_test_jobs`
		`- # rpm_test_jobs`
		`# rpminspect_jobs`
		`# [ rpm_linter_job ]`

zuul.d/jobs.yaml

file modified

-98

		`@@ -84,104 +84,6 @@`
		`url: https://kojipkgs.fedoraproject.org/repos/epel8-build/latest/x86_64/`

		`- job:`
		`- name: rpm-test`
		`- description: "Install the built rpms and run STI tests (rawhide variant)"`
		`- run: playbooks/rpm/rpmtest.yaml`
		`- post-run:`
		`- - playbooks/rpm/rpmtest-fetch-artifacts.yaml`
		`- branches:`
		`- - rawhide`
		`- - main`
		`- nodeset: fedora-rawhide-vm-medium`
		`- requires:`
		`- - repo`
		`- roles:`
		`- - zuul: zuul-distro-jobs`
		`- timeout: 18000`
		`- vars:`
		`- repos:`
		`- - name: distro-build`
		`- url: https://kojipkgs.fedoraproject.org/repos/rawhide/latest/x86_64/`
		`-`
		`- - job:`
		`- name: rpm-test`
		`- description: "Install the built rpms and run STI tests (f35 variant)"`
		`- run: playbooks/rpm/rpmtest.yaml`
		`- post-run:`
		`- - playbooks/rpm/rpmtest-fetch-artifacts.yaml`
		`- branches:`
		`- - f35`
		`- nodeset: fedora-35-vm-medium`
		`- requires:`
		`- - repo`
		`- roles:`
		`- - zuul: zuul-distro-jobs`
		`- timeout: 18000`
		`- vars:`
		`- repos:`
		`- - name: distro-build`
		`- url: https://kojipkgs.fedoraproject.org/repos/f35-build/latest/x86_64/`
		`-`
		`- - job:`
		`- name: rpm-test`
		`- description: "Install the built rpms and run STI tests (f34 variant)"`
		`- run: playbooks/rpm/rpmtest.yaml`
		`- post-run:`
		`- - playbooks/rpm/rpmtest-fetch-artifacts.yaml`
		`- branches:`
		`- - f34`
		`- nodeset: fedora-34-vm-medium`
		`- requires:`
		`- - repo`
		`- roles:`
		`- - zuul: zuul-distro-jobs`
		`- timeout: 18000`
		`- vars:`
		`- repos:`
		`- - name: distro-build`
		`- url: https://kojipkgs.fedoraproject.org/repos/f34-build/latest/x86_64/`
		`-`
		`- - job:`
		`- name: rpm-test`
		`- description: "Install the built rpms and run STI tests (f33 variant)"`
		`- run: playbooks/rpm/rpmtest.yaml`
		`- post-run:`
		`- - playbooks/rpm/rpmtest-fetch-artifacts.yaml`
		`- branches:`
		`- - f33`
		`- nodeset: fedora-33-vm-medium`
		`- requires:`
		`- - repo`
		`- roles:`
		`- - zuul: zuul-distro-jobs`
		`- timeout: 18000`
		`- vars:`
		`- repos:`
		`- - name: distro-build`
		`- url: https://kojipkgs.fedoraproject.org/repos/f33-build/latest/x86_64/`
		`-`
		`- - job:`
		`- name: rpm-test`
		`- description: "Install the built rpms and run STI tests (epel8 variant)"`
		`- run: playbooks/rpm/rpmtest.yaml`
		`- pre-run:`
		`- - playbooks/epel8/install.yaml`
		`- post-run:`
		`- - playbooks/rpm/rpmtest-fetch-artifacts.yaml`
		`- branches:`
		`- - epel8`
		`- nodeset: centos-8-vm`
		`- requires:`
		`- - repo`
		`- roles:`
		`- - zuul: zuul-distro-jobs`
		`- timeout: 18000`
		`- vars:`
		`- repos:`
		`- - name: distro-build`
		`- url: https://kojipkgs.fedoraproject.org/repos/epel8-build/latest/x86_64/`
		`-`
		`- - job:`
		`name: rpm-rpminspect`
		`parent: rpminspect`
		`description: "Run the rpminspect report tests (rawhide variant)"`

no initial comment

zuul commented 3 years ago

Zuul encountered a syntax error while parsing its configuration in the
repo fedora-zuul-jobs-config on branch master. The error was:

Job rpm-test not defined

The error appears in the following project stanza:

project:
name: rpms/selinux-policy
check:
jobs:
- rpm-test:
timeout: 21600

in "fedora-zuul-jobs-config/zuul.d/projects.yaml@master", line 101, column 3

fbo commented 3 years ago

you need to remove this first https://pagure.io/fedora-zuul-jobs-config/blob/master/f/zuul.d/projects.yaml#_101

guyinger commented 3 years ago

you need to remove this first https://pagure.io/fedora-zuul-jobs-config/blob/master/f/zuul.d/projects.yaml#_101

Removed in this PR: https://pagure.io/fedora-zuul-jobs-config/pull-request/144

zuul commented 3 years ago

This change depends on a change with an invalid configuration.

fbo commented 3 years ago

Sorry not remove but change "rpm-test" to "rpm-sti-test". We should be conservative and keep the override of the timeout.

fbo commented 3 years ago

Well it seems we will have trouble to merge those two PRs 144 and 128.
I suggest to do it step by step as explained here: https://pagure.io/fedora-zuul-jobs/pull-request/127#comment-162135

Could you open a PR that just do the step 4 ?

guyinger commented 3 years ago

Well it seems we will have trouble to merge those two PRs 144 and 128.
I suggest to do it step by step as explained here: https://pagure.io/fedora-zuul-jobs/pull-request/127#comment-162135

Could you open a PR that just do the step 4 ?

PR for step 4: https://pagure.io/fedora-zuul-jobs/pull-request/129

rebased onto b5e51e2

3 years ago

zuul commented 3 years ago

This change depends on a change that failed to merge.

zuul commented 3 years ago

Zuul encountered a syntax error while parsing its configuration in the
repo fedora-zuul-jobs on branch master. The error was:

Job rpm-test not defined

The error appears in the following project-template stanza:

project-template:
name: test-tests-def
check:
jobs:
- rpm-test

in "fedora-zuul-jobs/zuul.d/templates.yaml@master", line 63, column 3

fbo commented 3 years ago

We need to check if rpm-sti-test and/or rpm-tmt-test support this king of test (w/o the repo url passed to the API call)

mvadkert commented 3 years ago

@fbo, yep, that should be supported, you can omit environemnts[].artifacts, it is an optional field. If not passed, it will just run tests, without installing any packages from the repo.

mvadkert commented 3 years ago

@fbo, yep, that should be supported, you can omit environemnts[].artifacts, it is an optional field. If not passed, it will just run tests, without installing any packages from the repo.