#141 Add "distro" variable to Testing Farm jobs
Merged by zuul. Opened by guyinger.
guyinger/fedora-zuul-jobs-config add_distro  into  master

Download 141.patch

This is needed for https://pagure.io/fedora-ci/general/issue/298.

Build succeeded.

as discussed @guyinger it cannot be the same value, needs to be:

fedora-rawhide
fedora-33
fedora-34
fedora-35

And later

fedora-36

For Epel8 packages it should be:

centos-stream-8

https://fmf.readthedocs.io/en/stable/context.html

Etc.

@psss @lzachar ptal on distro values ... this will go to context from Zuul

rebased onto 443976a869fa61e23d7b808f116697d7fcc1fe0b

Changes applied. Ready for review.

Build succeeded.

fedora-X values are definitely OK. I can't tell about epel8. We just need to make sure that all PackIt/Zuul/ set same values

Is the compose name change expected here ?

Is the compose name change expected here ?

Yes, based on Miroslav's comment - "For Epel8 packages it should be:

centos-stream-8
https://fmf.readthedocs.io/en/stable/context.html
"

Ok then :thumbsup: from my side.
Waiting a confirmation from @mvadkert before merge

@guyinger compose for CentOS Stream 8 is CentOS-Stream-8, see:

http https://api.dev.testing-farm.io/v0.1/composes

rebased onto 9d4bd557a81debcd0405a7e65dd2c87790af0e9e

Build succeeded.

@guyinger compose for CentOS Stream 8 is CentOS-Stream-8, see:

http https://api.dev.testing-farm.io/v0.1/composes

Fixed.

As for now the distro dimension values in the tmt spec include the following examples:

  • fedora, fedora-33
  • centos, centos-8, centos-8.4
  • centos-stream, centos-stream-9
  • rhel, rhel-8, rhel-8.4

I see the patch uses centos-stream-8 instead. Is that expected? Shall we update the spec? Or both centos-8 and centos-stream-8 values will be used for the distro dimension of the context?

@mvadkert could you confirm values for distro and compose in his patch ? Should I merge now ? (then merge the follow up https://pagure.io/fedora-zuul-jobs/pull-request/126)

Also As we are adding this distro var for the role (should we update the centos stream zuul CI version too in https://gitlab.com/redhat/centos-stream/ci-cd/zuul/jobs-config/-/blob/master/zuul.d/jobs.yaml#L21-63 ?)

@fbo LGTM!

@psss aha yeah well, we do want to use centos-stream-8 yeah, centos-8 will be EOL soon, we should update the spec

rebased onto 84d6b65ead17b04846a29d4c9f650899ca4bca43

Build succeeded.

Metadata Update from @fbo:
- Pull-request tagged with: gateit

Build succeeded (gate pipeline).

Pull-Request has been merged by zuul

Metadata