In https://src.fedoraproject.org/rpms/openssl/pull-request/21 I (re)add tests/tests_python.yml, but Zuul's check-for-tests / check-for-sti-tests job does not recognize that file. I've looked in the implementation here and it only explicitly checks for tests/tests.yml:
tests/tests_python.yml
tests/tests.yml
https://pagure.io/fedora-zuul-jobs-config/blob/master/f/playbooks/rpm/check-for-tests.yaml https://pagure.io/fedora-zuul-jobs-config/blob/master/f/playbooks/rpm/check-for-sti-tests.yaml
However, the specification explicitly says:
The testing system MUST run each playbook matching the glob tests/tests*.yml in the dist-git repo.
tests/tests*.yml
I'd submit a fix, but I don't know how to write a check for glob-existence in this yaml playbook.
Here is a proposal to fix this. Please review: https://pagure.io/fedora-zuul-jobs-config/pull-request/155
I've restarted https://src.fedoraproject.org/rpms/openssl/pull-request/21
Still skipped.
Unfortunately the fix does not work: I'll merging this now https://pagure.io/fedora-zuul-jobs-config/pull-request/156 and see.
Yes that's due to that failure: https://fedora.softwarefactory-project.io/logs/21/21/e251b765e5791db1761c4ba4bcbc12b21fb666e4/check/check-for-tests/e39ae65/job-output.txt.gz
The new fix seems to fix this. Please retry.
The test detection now works, but rpm-test does not:
mkdir -p tests && find . tests -maxdepth 1 -type f -name tests.yml | head -1 | xargs dirname non-zero return code dirname: missing operand Try 'dirname --help' for more information.
https://src.fedoraproject.org/rpms/openssl/pull-request/21#comment-100687
rpm-sti-test works.
Please try with: Depends-on: https://pagure.io/fedora-zuul-jobs/pull-request/138
Added.
Seems to work properly, thanks.
Thanks for the test. The change is now merged. I close here. Please re-open if needed.
Metadata Update from @fbo: - Issue status updated to: Closed (was: Open)
Thanks for the fix!
Login to comment on this ticket.