Issue #180: F34: Drop gtk2 from Workstation default install - fedora-workstation

+1 from me.

@stransky @xhorak would it be possible to do what @kalev is suggesting for Firefox?

@jkonecny do you have an idea why Anaconda still requires gtk2?

stransky commented 3 years ago

+1 from me.

@stransky @xhorak would it be possible to do what @kalev is suggesting for Firefox?

No, we're no going to do any work here as we have lot of more important task to do.
Firefox will drop gtk2 support when flash support is removed which is planned to end of 2020 or so.

https://developer.mozilla.org/en-US/docs/Plugins/Roadmap

No, we're no going to do any work here as we have lot of more important task to do.
Firefox will drop gtk2 support when flash support is removed which is planned to end of 2020 or so.

Do you have a link to some Mozilla tracker, where we can follow the Flash support removal? If you say end of 2020, then no action will really be required.

stransky commented 3 years ago

jkonecny commented 3 years ago

Hi, finally I was able to find the dependency tree to gtk2.

It's like this:
anaconda-live
anaconda-gui
blivet-gui-runtime
lxpolkit
gtk2

So the first dependency from Anaconda dragging in gtk2 is blivet-gui-runtime. @vtrefny could you please look if you can get rid of this dependency?

Hi, finally I was able to find the dependency tree to gtk2.

It's like this:
anaconda-live
anaconda-gui
blivet-gui-runtime
lxpolkit

Instead of using lxpolkit, could https://src.fedoraproject.org/rpms/polkit-gnome be used?

blivet-gui-runtime specifically asks for PolicyKit-authentication-agent, which polkit-gnome identifies as a provider for. So if our gnome-desktop group already includes that, then Anaconda won't pull it in and it won't need GTK2.

blivet-gui-runtime specifically asks for PolicyKit-authentication-agent, which polkit-gnome identifies as a provider for. So if our gnome-desktop group already includes that, then Anaconda won't pull it in and it won't need GTK2.

It isn't there..

Sounds like we should add it to our comps groups, which is something we should do even for F33...

vtrefny commented 3 years ago

I can move the polkit dependency from blivet-gui-runtime to blivet-gui. It isn't really needed for the runtime package, I need it to start the application so it's not needed when running from Anaconda.

Regardless of where it is, we should have polkit-gnome installed in Fedora Workstation media so that it uses that instead of installing lxpolkit.

vtrefny commented 3 years ago

Of course, but Anaconda depends only on blivet-gui-runtime not on blivet-gui so moving the dependency would also fix the issue for default installation.

blivet-gui depended directly on polkit-gnome in the past, but that meant installing blivet-gui in KDE or Xfce systems pulled in a lot of GNOME specific dependencies.

Regardless of where it is, we should have polkit-gnome installed in Fedora Workstation media so that it uses that instead of installing lxpolkit.

No. gnome-shell already provides a policykit authentication agent. polkit-gnome is obsolete and not needed for Fedora Workstation.

No, we're no going to do any work here as we have lot of more important task to do.
Firefox will drop gtk2 support when flash support is removed which is planned to end of 2020 or so.

Do you have a link to some Mozilla tracker, where we can follow the Flash support removal? If you say end of 2020, then no action will really be required.

I can help with the required firefox packaging work to subpackage the flash support if they should decide to keep it alive past the end of 2020.

Regardless of where it is, we should have polkit-gnome installed in Fedora Workstation media so that it uses that instead of installing lxpolkit.

No. gnome-shell already provides a policykit authentication agent. polkit-gnome is obsolete and not needed for Fedora Workstation.

Then gnome-shell should Provides: PolicyKit-authentication-agent if that's actually true.

Done: https://src.fedoraproject.org/rpms/gnome-shell/c/cd9369de85703b98ededeee30f9a421bbb7ebc30?branch=master

No. gnome-shell already provides a policykit authentication agent. polkit-gnome is obsolete and not needed for Fedora Workstation.

Then gnome-shell should Provides: PolicyKit-authentication-agent if that's actually true.

... and I went ahead and requested a F33 freeze exception for the change so that we can get rid of lxpolkit for the beta release: https://bugzilla.redhat.com/show_bug.cgi?id=1872686

chrismurphy commented 3 years ago

Fedora-Workstation-Live-x86_64-Rawhide-20210116.n.1.iso has the following:

adwaita-gtk2-theme-3.28-9.fc33.x86_64
gtk2-2.24.33-2.fc34.x86_64
ibus-gtk2-1.5.23-2.fc34.x86_64
libcanberra-gtk2-0.30-23.fc33.x86_64

Removing gtk2 removes the above and also removes:

firefox
pinentry-gtk
libva

Rawhide currently has firefox 84, which is the last version to support flash. Firefox 85 is expected to be released Jan 26.

But I'm not sure about the other two.

pinentry-gtk: Pinentry is a collection of simple PIN or passphrase entry dialogs which utilize the Assuan protocol as described by the aegypten project; see http://www.gnupg.org/aegypten/ for details.
I really don't know why it's preinstalled.

Regarding libva - I don't see it depends on gtk2 (https://koji.fedoraproject.org/koji/rpminfo?rpmID=24298475). I think that firefox depends on it and libva is removed when you remove firefox - see the "Recommends" in https://koji.fedoraproject.org/koji/rpminfo?rpmID=24615895.

We should be using pinentry-gnome3 (it's listed in comps) instead of pinentry-gtk. I am not sure what pulls it in (probably some kind of conditional dep), but hopefully it goes away when the rest of gtk2 is gone from the default install. If not, we can investigate it further.

Comps PR to drop libcanberra-gtk2: https://pagure.io/fedora-comps/pull-request/589

The rest is just firefox pulling in gtk2 as much as I can tell, and should go away as soon as next firefox build hits the repos, if I understand firefox changes correctly.

Action: Tomas to talk to @stransky about removing the GTK2 dependency (including gtk2-plugin-container or what else)

Here's a PR to drop gtk2 support from firefox: https://src.fedoraproject.org/rpms/firefox/pull-request/29

The PR has been merged. Now we should check a new compose and see if it is indeed gone.

https://src.fedoraproject.org/rpms/evolution-data-server/c/f2629ec293caa0c964725431ee01b7cc7542e224?branch=rawhide

gtk2 was still not gone in the latest compose. I did some debugging and it turned out that evolution-data-server was pulling in pinentry-gtk, (gtk2-based), so we had both pinentry-gtk and pinentry-gnome3 (this is the one we want) installed.

I went ahead and changed the dep in to pinentry-gui virtual provide, which should hopefully make it so that we only have pinentry-gnome3 installed on the media.

Need to check again after next compose to see if this was now enough to get rid of gtk2 :)

This still didn't drop gtk2 from install media, so I tracked down one more place that pulls it in: gnome-themes-extra. Should be fixed in https://src.fedoraproject.org/rpms/gnome-themes-extra/c/137cf9f5579324439a7ced863293aa02eb1eff5d?branch=rawhide

mclasen commented 3 years ago

Is there any point in including gnome-themes-extra at this point ?

From what I can see, it has a bunch of HighContrast app icons - don't we just use symbolics for that nowadays?

I'll double-check with Jakub

It also ships an empty /usr/share/themes/Adwaita/gtk-3.0/gtk.css which I believe gnome-tweaks uses to show which themes are available. Can we just put the empty file in gtk3 ?

This is the code from gnome-tweaks:

    def _get_valid_themes(self):
        """ Only shows themes that have variations for gtk3"""
        gtk_ver = Gtk.MINOR_VERSION
        if gtk_ver % 2: # Want even number
            gtk_ver += 1

        valid = ['Adwaita', 'HighContrast', 'HighContrastInverse']
        valid += walk_directories(get_resource_dirs("themes"), lambda d:
                    os.path.exists(os.path.join(d, "gtk-3.0", "gtk.css")) or \
                         os.path.exists(os.path.join(d, "gtk-3.{}".format(gtk_ver))))
        return set(valid)

mclasen commented 3 years ago

I don't see any problem with moving that css file to gtk3

@mclasen, https://src.fedoraproject.org/rpms/gtk3/pull-request/7 ?

Should I do the same for upstream as well?

mclasen commented 3 years ago

gnome-tweaks could just know that Adwaita + HighContrast is always going to be available (since it links against gtk3, which includes those themes), but sure, why not

I think I remember discussion around this a few years ago and back then gnome-tweaks developers said that they didn't want to hardcode a theme list because this (the existence of gtk.css) is the only API they have or something. (I suspect the real reason was Ubuntu maybe included extra themes that would have complicated things).

Woohoo, looks like gtk2 is finally gone from today's rawhide compose.

... and gtk2 is back, due to the switch to ibus-anthy that pulls in kasumi-unicode which in turn pulls in gtk2. I've filed https://bugzilla.redhat.com/show_bug.cgi?id=1928410

Looks like that should be fixed and we just need to verify again that it's really gone.

It's a shame this has to be done manually. Ideally we would have some automated unwanted package test that would fail if a particular package is installed....

Metadata Update from @catanzaro:
- Issue tagged with: pending-action

3 years ago

It's a shame this has to be done manually. Ideally we would have some automated unwanted package test that would fail if a particular package is installed....

Adam has offered to create an openqa test to ensure gtk2 doesn't return. We could add other unwanted packages too, if desired.

Metadata Update from @kalev:
- Issue untagged with: pending-action
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

3 years ago