fedora-web / websites

#86 coreos-download: add bootstrap modal for verification
Merged by dustymabe. Opened by abai.
fedora-web/ abai/websites coreos-download  into  master

Download 86.patch

Changes the signature and SHA256 verification UI from in-place
div insersion to a bootstrap modal.

Signed-off-by: Allen Bai abai@redhat.com

screenshot demo

Previous UI require users to scroll horizontally to view the content. Using bootstrap modal can help with the situation, although additional clicking/typing to close the popup modal is required, which could be bad for user experience.

cc @rfairley @jlebon

This is pretty great. I agree the current setup isn't as clean as it could be.
Haven't looked at the code yet, but the idea overall makes a lot of sense to me!

I'm not familiar with building a UI by code like this but it seems sane.
/cc @dustymabe

Not necessarily for this PR, though I wonder if it'd be cleaner to instead fold these links into step 1. E.g. something like:

SHA256: ...

  1. Download the checksum file and signature
  2. Import Fedora's GPG keys
    ...etc

WDYT?

@jlebon I think combine the links into a step sounds cleaner. Updating

combined links screenshot
Looks cleaner to me :+1:
Edited by abai

1 new commit added

  • coreos-download: combine links for signature and checksum

Neat! Maybe just smallcase C and S for checksum file and Signature?

2 new commits added

  • coreos-download: combine links for signature and checksum
  • coreos-download: add bootstrap modal for verification

LGTM - though IANA web developer :)

Pull-Request has been merged by dustymabe
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.