#125 coreos-download: clean up AWS cloud launchable regions
Merged by dustymabe. Opened by abai.
fedora-web/ abai/websites coreos-download  into  master

Download 125.patch

This changes cleans up AWS cloud launchable regions such that by default only us-east-1 is displayed and only display other regions when pressing the "show all regions" button.

Additional changes include updating the "View Releases" button to link to corresponding stream in release note page instead of to default stable stream, and minor styling modifications. Also, split cloud operators tab into two columns.

Signed-off-by: Allen Bai abai@redhat.com

rebased onto ba82f0c2de3053548922153c6448cbe6fe888920

1 new commit added

  • coreos-download: format coreos-release-notes and coreos-download

Formatted coreos-release-notes.js and coreos-download.js as a follow-up commit.

Image demo:
hide regions
show regions
two-column cloud images

cc @bgilbert @dustymabe @jlebon

Looks great!

Yes, looks good to me as well!

It looks like the "testing" stream name moved from beside the version to under the cloud name? Is there a reason for that?

Re. the "show all regions" button, it feels a bit odd IMO to have it beside the stream name. I think it'd make more sense on its own beside the cloud name? (Or maybe just on its own, right under).

@jlebon
I was thinking the original version might have repeated the stream too many times so changed to this to get some reviews from ppl. I don't have strong preference so I'm happy to revert it back but I do wanted to get some feedback. Also, what do you think about the "verbose" level of current display, I wonder if the newly added "Region, Release, Image" keys will distract users from finding essential information.

re. "show all regions": Sure, I will try both ways locally, but I do think beside the cloud name "AWS" might be cleaner.

If the release is always the same for all regions maybe we should only show it once at the top?

This looks great. One question: Would it make sense to just have a dropdown box where you select a region instead of the button to "show all regions"? That way the UI wouldn't all of a sudden get 12 more entries and the users could just select the region they want.

@dustymabe that makes sense, will update with a dropdown selector if it works

rebased onto cd4acc1a4dc513dbe228fd1e445174a347d78cdb

Updated with a region selector dropdown:
GIF:
gif demo
Screenshot_0:
screenshot0
Screenshot_1:
screenshot1

Ready for another look :)

Looks much better to me!

The only thing that looks a bit odd is how the GCP field doesn't have Release but AWS does. Maybe we could add Release to GCP too and move Release for both AWS and GCP up to the top directly under (or maybe even beside) the stream name.

Perfectly happy to merge this the way it is, though!

I think the reason for that is that the stream metadata accommodates the possibility for some regions to be on older releases if necessary. For parity, the .images.gcp should probably also have a release field, which we could then print here when expanding details on the GCP image?

+1 to merge as is and do more tweaks as follow-ups!

Pull-Request has been merged by dustymabe

Looks great!

Metadata