From c3de6365753c3c12d5c1351db8838f94bfc74ceb Mon Sep 17 00:00:00 2001
From: Allen Bai <abai@redhat.com>
Date: Jun 03 2020 17:05:49 +0000
Subject: coreos-release-note: fix error produced when calculating pkgdiffs


This error was not found previously since the conditional block was
not hit when calculating pkgdiffs. Essentially the accumulated pkgdiff
is an array of arrays, and the previous code lacks a layer of indexing
to modify the individual pkgdiff info.

In the future, more error checkings need to be added to handle this kind
of situations more gracefully.

Signed-off-by: Allen Bai <abai@redhat.com>

---

diff --git a/sites/static/js/coreos-release-notes.js b/sites/static/js/coreos-release-notes.js
index c491a45..94c5184 100644
--- a/sites/static/js/coreos-release-notes.js
+++ b/sites/static/js/coreos-release-notes.js
@@ -190,10 +190,10 @@ function getPkgDiffFromMetaList (metaList) {
             } else if (strcmp(pkgDiffAccCpy[i][2].NewPackage[1], pkgInfo.PreviousPackage[1]) > 0) {
               // overall, an upgrade
               pkgDiffAccCpyp[i] = d;
-              pkgDiffAccCpy[i].NewPackage[1] = dAcc[2].NewPackage[1];
+              pkgDiffAccCpy[i][2].NewPackage[1] = dAcc[2].NewPackage[1];
             } else {
               // overall, a downgrade
-              pkgDiffAccCpy[i].PreviousPackage[1] = pkgInfo.PreviousPackage[1];
+              pkgDiffAccCpy[i][2].PreviousPackage[1] = pkgInfo.PreviousPackage[1];
             }
             break;
           }
@@ -221,11 +221,11 @@ function getPkgDiffFromMetaList (metaList) {
               pkgDiffAccCpy[i] = [];
             } else if (strcmp(pkgDiffAccCpy[i][2].NewPackage[1], pkgInfo.PreviousPackage[1]) > 0) {
               // overall, an upgrade
-              pkgDiffAccCpy[i].PreviousPackage[1] = pkgInfo.PreviousPackage[1];
+              pkgDiffAccCpy[i][2].PreviousPackage[1] = pkgInfo.PreviousPackage[1];
             } else {
               // overall, a downgrade
               pkgDiffAccCpyp[i] = d;
-              pkgDiffAccCpy[i].NewPackage[1] = dAcc[2].NewPackage[1];
+              pkgDiffAccCpy[i][2].NewPackage[1] = dAcc[2].NewPackage[1];
             }
             break;
           }