PR#56: main: create intermediate directories for cachedir - fedora-rust/rust2rpm

fedora-rust / rust2rpm

#56 main: create intermediate directories for cachedir

Merged 5 years ago by ignatenkobrain. Opened 5 years ago by lucab.

fedora-rust/ lucab/rust2rpm ups/makedirs-fix into master

main: create intermediate directories for cachedir

Luca Bruno • 5 years ago

77d4c65

rust2rpm/__main__.py

file modified

+1 -1

		`@@ -102,7 +102,7 @@`
		`version = next(version["num"] for version in versions if not version["yanked"])`

		`if not os.path.isdir(CACHEDIR):`
		`- os.mkdir(CACHEDIR)`
		`+ os.makedirs(CACHEDIR)`
zbyszek commented 5 years ago Hmm, while at it, maybe just use `makedirs(exists_ok=True)` ?
ignatenkobrain commented 5 years ago agree with @zbyszek. add `exists_ok=True` and I'm +1
		`cratef_base = "{}-{}.crate".format(crate, version)`
		`cratef = os.path.join(CACHEDIR, cratef_base)`
		`if not os.path.isfile(cratef):`

lucab commented 5 years ago

Fixes: https://pagure.io/fedora-rust/rust2rpm/issue/50

zbyszek commented on line 6 of rust2rpm/__main__.py 5 years ago

Hmm, while at it, maybe just use makedirs(exists_ok=True) ?

lucab commented 5 years ago

@zbyszek without the conditional on isdir? I don't like relying on implicit side-effects too much, but I can change to do that if we prefer.

ignatenkobrain commented on line 6 of rust2rpm/__main__.py 5 years ago

agree with @zbyszek. add exists_ok=True and I'm +1

zbyszek commented 5 years ago

That's what I head in mind. With makedirs we are already relying on side effects for the intermediate dirs, so just doing an explicit check for the last path element doesn't seem useful.

ignatenkobrain commented 5 years ago

Commit 2c1e19f fixes this pull-request