#49 macros: add bootstrapping macro
Closed 5 years ago by ignatenkobrain. Opened 6 years ago by ignatenkobrain.

file modified
+1
@@ -1,1 +1,2 @@ 

  %rust_arches x86_64 i686 armv7hl aarch64 ppc64 ppc64le s390x

+ %with_rust_bootstrap 0

The idea of this is to avoid circular dependencies. And in future to use it from cargo/rust itself.

@ngompa @jistone review is appreciated.

Looks okay to me, but how do you envision using it?

@ngompa

%if %{with rust_bootstrap}
%bcond_with check
%else
%bcond_without check
%endif

for example. Or in rust it would use prebuilt binaries.

Do you plan to have some kind of automated rebootstrapping workflow for this?

@ngompa, well, you set bootstrap macro here, rebuild rust-srpm-macros, find where it is used, rebuild that stuff.

So... No, then? ;)

Anyway, looks okay to me.

I don't think this belongs as a global macro. Bootstrapping is a concern that is local to a package, or a group of packages, but not necessarily the whole distro. For instance, when you bootstrapped crates recently on F27, that did not need to trigger rustc and cargo to build from upstream binaries again. Or on the flip side, if I have to re-bootstrap rustc or cargo due to some library soname change, I don't need to affect other crate bootstraps.

Binary bootstraps always need to be deliberate, so we're sure to also rebuild it cleanly afterward. So I don't think I would use this global macro for rustc and cargo, at least.

Pull-Request has been closed by ignatenkobrain

5 years ago
Metadata