@churchyard it would be great if you could take a look at this, if you have the time. I haven't done python packaging in a while, so I needed to look at the docs for how to do this correctly ...

First I moved all our imperative setuptools configuration from setup.py to a declarative configuration in setup.cfg according to: https://setuptools.pypa.io/en/latest/userguide/declarative_config.html

Then I deleted the now-empty setup.py file and created a minimal pyproject.toml file: https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html

I'm pretty sure at least some of the settings that are in setup.cfg right now could be moved to pyproject.toml as well, but once I was at that point, the documentation wasn't really that great.

At least the way I've done it now, projects settings are in setup.cfg, while build / tool settings are in pyproject.toml, which seems like a nice separation of concerns.

I've tested that running pip install . --use-pep517 in a virtualenv already works without warnings or error messages. Though I'm not sure if it actually identifies "rust2rpm" and "rust2rpm.core" as different packages (or if it even needs to?), and since that's one of the main improvements that I want to make to the packaging of the next rust2rpm version, it would be great if that worked as expected from the python side of things :)

Though I'm not sure if it actually identifies "rust2rpm" and "rust2rpm.core" as different packages (or if it even needs to?)

It never did ;) And it does not need to.

Back in the day, this needed setuptools and wheel. But if it works without, so be it.

Thanks for taking a look!

It never did ;) And it does not need to.

Ok, good to know.

Back in the day, this needed setuptools and wheel. But if it works without, so be it.

I don't think it needs "wheel" to work:

rm -rf venv
python3 -m venv venv
source venv/bin/activate
pip install . --use-pep517       # works without errors

• I've installed from the origin main branch with --use-pep517.
• I've installed from your main branch with --use-pep517.
• I've diffed the results

--- venv-origin/lib/python3.10/site-packages/rust2rpm-21.dist-info/METADATA 2022-07-23 12:08:38.286803164 +0200
+++ venv-pr/lib/python3.10/site-packages/rust2rpm-21.dist-info/METADATA 2022-07-23 12:08:53.780889455 +0200
@@ -1,12 +1,12 @@
 Metadata-Version: 2.1
 Name: rust2rpm
 Version: 21
-Summary: Convert Rust crates to RPM
+Summary: Generate RPM packages for Rust crates
 Home-page: https://pagure.io/fedora-rust/rust2rpm
-Author: Igor Gnatenko
-Author-email: ignatenkobrain@fedoraproject.org
+Author: Fedora Rust SIG
+Author-email: rust@lists.fedoraproject.org
 License: MIT
-Keywords: rust cargo rpm
+Keywords: rpm,cargo,rust
 Classifier: Development Status :: 5 - Production/Stable
 Classifier: Intended Audience :: Developers
 Classifier: License :: OSI Approved :: MIT License
@@ -21,6 +21,69 @@
 Classifier: Topic :: Utilities
 License-File: LICENSE
 Requires-Dist: jinja2
+Requires-Dist: pyparsing
 Requires-Dist: requests
 Requires-Dist: tqdm

+# rust2rpm
+
+rust2rpm is a tool... (the entire README omitted here)

The venv also differed because it newly has pyparsing. I see the change is a separate commit, so good.

No idea about the black configuration, I don't use it.

I don't think it needs "wheel" to work...

I suppose setuptools will generate the wheel requirement in the next step. It's nicely visible when building RPM packages. Possibly also visible when pip is told to be more verbose, but not sure.

Ah yes, I see this if I run pip install . --with-pep517 --verbose:

(...)
  Running command /home/deca/Workspace/rust2rpm/venv/bin/python3 /tmp/pip-standalone-pip-asdvz7z6/__env_pip__.zip/pip install --ignore-installed --no-user --prefix /tmp/pip-build-env-xi0noc9y/normal --no-warn-script-location --no-binary :none: --only-binary :none: -i https://pypi.org/simple -- wheel
  Collecting wheel
    Using cached wheel-0.37.1-py2.py3-none-any.whl (35 kB)
  Installing collected packages: wheel
  Successfully installed wheel-0.37.1
(...)

So should I add "wheel" to the build-system.requires list in pyproject.toml?

I've diffed the results

So I think the diff looks good? :) All the changed lines look like they were caused by intentional changes on my side.

So should I add "wheel" to the build-system.requires list in pyproject.toml?

No.

Ok, thanks :)