fedora-rust / rust2rpm

Clone
Source Code
GIT

#148 rust2rpm: replace hyphens by underscores in version
Merged 2 years ago by zbyszek. Opened 2 years ago by dangoncalves.
fedora-rust/ dangoncalves/rust2rpm issue_124  into  master

file modified
+2 -2 
@@ -75,9 +75,9 @@ 
 

          version_str = f'{version.major}.{version.minor or 0}' \
 

              f'.{version.patch or 0}'
 

          if version.pre_release:
 

-             version_str = f'{version_str}{sep}{version.pre_release}'
 

+             version_str = f'{version_str}{sep}{version.pre_release.replace("-", "_")}'
 

          if version.build:
 

-             version_str = f'{version_str}+{version.build}'
 

+             version_str = f'{version_str}+{version.build.replace("-", "_")}'
 

          return version_str
 

  

      @staticmethod

  • fix issue#124

@ignatenkobrain said that this is OK. Let's merge then.

rebased onto 2523fd3
2 years ago

Pull-Request has been merged by zbyszek
2 years ago

Do we have test coverage for this function? It would be good to make sure that semver ←→ RPM version translation remains stable over time.

Nope, we don't have any tests for this aspect. I agree it would be great to add some.
Edited 2 years ago by zbyszek
Metadata
None
No Tags
Changes Summary 1
+2 -2
file changed
rust2rpm/metadata.py
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.