#192 Could version_no_tilde() be moved?
Opened 2 months ago by eclipseo. Modified 12 days ago

Could we move version_no_tilde() in order to use it in any package besides Rust ones?

Thanks.


What would you want to use it for? I'm not sure if it would be generally applicable, though.

The macro very specifically converts RPM version strings that were converted from cargo's version of the SemVer format when running rust2rpm into cargo's version of the SemVer format again, so there's probably some details in there that won't make sense or work anywhere else.

I'm fine with moving it out, the reason @ignatenkobrain and I put it here was because of a lack of better options. It's not SemVer specific at all, it follows the rules that a lot of projects use for pre-release Git tags. It also made it easier to keep the macros cross-distro portable.

I would rather have this utility macro moved into rpm itself, that way the macros still work across distributions.

I'm fine with moving it. Ideally, somebody would submit a pull request to some other place, and once that becomes available, we'd drop our copy.

I can submit this to redhat-rpm-config. I agree with @ngompa's assessment of this being more generally applicable. Personally, I would like to use this in the ansible macros, which currently don't properly support pre-releases.

However, the licensing is a bit of a problem, as this repo is MIT and redhat-rpm-config is GPL+. Unless we decide that this isn't a "substantial [portion] of the Software" or get @ignatenkobrain's permission, we'd have to add a copy of the MIT license to and change the License of redhat-rpm-config package to GPL+ and MIT.

Closed #218 in favor of this issue.

I can submit this to redhat-rpm-config.

redhat-rpm-config is the wrong place for this, since that is Fedora-specific and Rust macros are cross-distro.

I can submit this to redhat-rpm-config.

redhat-rpm-config is the wrong place for this, since that is Fedora-specific and Rust macros are cross-distro.

So I guess getting it into rpm itself is the only option?

Login to comment on this ticket.

Metadata