#165 existence-check is annoying for new (compat) packages
Closed: Fixed 2 years ago by zbyszek. Opened 2 years ago by decathorpe.

  • request compat package repo
  • fedpkg clone it
  • try to run rust2rpm for it

Get this message:

Crate tiny_http0.6 is already packaged in Fedora (https://src.fedoraproject.org/rpms/rust-tiny_http0.6).
Re-run with --no-existence-check if you still want to convert it.

Even if the package does not "technically" exist yet, only the dist-git repo was created before rust2rpm was run / the .spec file was created.


Maybe the existence check can be skipped if the --suffix argument is used? That should solve the problem for most cases ...

The presence of --suffix is not a good test: you might just as well create a suffixed package by mistake as a non-suffixed one.

I think that in this workflow it is reasonable to add --no-existence-check: you know that the repo is there.

But I think we can automatize this: check if the spec file is present in the repo. We have the url of dist-git, so we can do that fairly easily. We do the existence check for Fedora only right now. Different distros might have different rules, so it would be hard to do in the general case. But we don't implement this there anyway.

Right - if the .spec URL is 404 (i.e. https://src.fedoraproject.org/rpms/rust-libc/blob/rawhide/f/rust-libc.spec ) then the package hasn't been imported yet.

Commit 73f5d59 fixes this issue

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #166 Merged 2 years ago