#124 rust2rpm for upstream crates with multiple hyphens in the version broken
Closed: Fixed 2 years ago by zbyszek. Opened 3 years ago by decathorpe.

For example:

https://crates.io/crates/wasi/0.10.2+wasi-snapshot-preview1

Generates this Version tag: 0.10.2+wasi-snapshot-preview1


What is the proposal on how you would normalise this? It would be good to know so that I can be consistent with cargo-lock2rpmprovides in the provides lines we generate.

I'd replace - by _ and that's it.

0.10.2+wasi-snapshot-preview1 would become 0.10.2+wasi_snapshot_preview1in this case? Or would you also normalise the + to a -?

We cannot use - for anything.

I created this PR that should fix this issue. Feel free to give any feedback.

#148 was merged, this should be fine now.

Metadata Update from @zbyszek:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

2 years ago

Login to comment on this ticket.

Metadata