Currently, "Login via OIDC" doesn't make sense to most users, they have no idea what OIDC is. I would change it to "Login with a Fedora account".
Do we need/want to support other providers than OIDC than Fedora? Is there supposed to be a selector (Google, etc) after clicking the button? Personally, I think supporting just Fedora accounts is OK.
Furthermore, it's currently unclear whether Displayname and Captcha need to be filled out before clicking the Login via OIDC button. Ideally I would initially just display the two buttons - "Login with a Fedora account" and "Anonymous login", and only if "Anonymous login" is clicked, the form with Displayname and Captcha would be shown.
We could also add a note under the Anonymous login, that results editing is possibly only in the same browser and until logout (or session expires). For long-term editing functionality, an identified login is needed.
You could technically copy the session into another browser. It has a lifespan of one day, which IMO is enough (I considered to be shorter, but this felt like an OK compromise).
Also note, that addinng more OIDC providers is non-straight-forward, since the python oidc library we use does not support it.
This is what we use: https://flask-oidc.readthedocs.io/en/latest/# , for no other reason that it was the preferred infra solution when we first started to add OAuth logins.
There certainly are other Python OIDC clients, and changing the library should not be (famous last words) super complicated. I can help out/consult if this becomes wanted.
adding more OIDC providers is non-straight-forward
Does this mean this will be hardcoded to go to FAS auth page anyway? So there will be no choice, and we can easily just rename the button? (It's all thumbs up by me, just want to clarify it).
Yes.
Anyway, it absolutely makes sense to make the login form clearer, it was a MVP :)
Solved by 7e04654
Metadata Update from @jskladan: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
Log in to comment on this ticket.