From 0fe88a2964680d40075bd43105a9850fd9b5ce91 Mon Sep 17 00:00:00 2001
From: Brandon Nielsen <nielsenb@jetfuse.net>
Date: Nov 05 2022 15:53:42 +0000
Subject: Cleanup unreachble code for coverage reasons.


Remove `if not version_type` conditional:

`version_type` is explicitly set to '', and `not ''` will always evaluate
to `True`.

---

diff --git a/src/relval/report_results.py b/src/relval/report_results.py
index 26626f2..7d3636a 100644
--- a/src/relval/report_results.py
+++ b/src/relval/report_results.py
@@ -209,13 +209,10 @@ def report_results(
         release = int(get_response(prompt, helptext, accepted=validrels))
 
     while not version_set:
-        if not version_type:
-            prompt = (
-                "Would you like to report a result for a milestone "
-                "(c)ompose or a (n)ightly compose? "
-            )
-            helptext = "Please choose (c)ompose or (n)ightly."
-            version_type = get_response(prompt, helptext, accepted=("c", "n"))
+        prompt = ("Would you like to report a result for a milestone "
+                  "(c)ompose or a (n)ightly compose? ")
+        helptext = "Please choose (c)ompose or (n)ightly."
+        version_type = get_response(prompt, helptext, accepted=('c', 'n'))
 
         if version_type == "c":
             prompt = "(B)eta\n(R)C\nWhich milestone would you like to report a milestone for? "