#94 Fixes 'show orphanned' typo
Closed 3 years ago by alciregi. Opened 3 years ago by alciregi.
fedora-qa/ alciregi/packager_dashboard master  into  master

@@ -173,7 +173,7 @@ 

              name="show_orphaned"

              value={show_orphaned}

              handler={this.handle("general")}>

-             <div className="font-weight-bold">Show orphanned</div>

+             <div className="font-weight-bold">Show orphaned</div>

            </OptionsSwitch>

  

            <OptionsSwitch name="show_koschei" value={show_koschei} handler={this.handle("general")}>

"Show orphanned": shouldn't it be "Show orphaned"?

Thanks for fixing the typo. Before we merge this, please change the commit message to something representative of what the changes are (e.g. "Fixes 'show orphanned' typo"), not which files are changed.

Hu. How to edit the commit message? (I used pagure web interface)

Amend the commit in your local Git repo, force push, and the commit message will get changed, since the PR is created as a difference between your branch and our master. You seem to have changed the PR's name/text via the web gui, which will not get reflected on the commit message.
TY

Note that when people make trivial fixes via the web UI, switching to the "you need to clone this and amend it" workflow is very tedious, so I'll do it for you.

2 new commits added

  • Merge branch 'master' of ssh://pagure.io/forks/alciregi/fedora-qa/packager_dashboard
  • Fix 'show orphanned' typo
3 years ago

Oh. OK.
I close this one then.
Thank you.

Pull-Request has been closed by alciregi

3 years ago
Metadata