PR#94: Fixes 'show orphanned' typo - fedora-qa/packager_dashboard

fedora-qa / packager_dashboard

#94 Fixes 'show orphanned' typo

Closed 4 years ago by alciregi. Opened 4 years ago by alciregi.

fedora-qa/ alciregi/packager_dashboard master into master

Merge branch 'master' of ssh://pagure.io/forks/alciregi/fedora-qa/packager_dashboard

Alessio • 4 years ago

0ed9282

Fix 'show orphanned' typo

Alessio • 4 years ago

6146c0c

Update src/components/Options/index.js

Alessio • 4 years ago

0707ae4

src/components/Options/index.js

file modified

+1 -1

		`@@ -173,7 +173,7 @@`
		`name="show_orphaned"`
		`value={show_orphaned}`
		`handler={this.handle("general")}>`
		`- <div className="font-weight-bold">Show orphanned</div>`
		`+ <div className="font-weight-bold">Show orphaned</div>`
		`</OptionsSwitch>`

		`<OptionsSwitch name="show_koschei" value={show_koschei} handler={this.handle("general")}>`

alciregi commented 4 years ago

"Show orphanned": shouldn't it be "Show orphaned"?

jskladan commented 4 years ago

Thanks for fixing the typo. Before we merge this, please change the commit message to something representative of what the changes are (e.g. "Fixes 'show orphanned' typo"), not which files are changed.

alciregi commented 4 years ago

Hu. How to edit the commit message? (I used pagure web interface)

jskladan commented 4 years ago

Amend the commit in your local Git repo, force push, and the commit message will get changed, since the PR is created as a difference between your branch and our master. You seem to have changed the PR's name/text via the web gui, which will not get reflected on the commit message.
TY

churchyard commented 4 years ago

Note that when people make trivial fixes via the web UI, switching to the "you need to clone this and amend it" workflow is very tedious, so I'll do it for you.

churchyard commented 4 years ago

https://pagure.io/fedora-qa/packager_dashboard/pull-request/95

2 new commits added