fedora-qa / packager_dashboard

Clone
Source Code
GIT

#63 FedoraCI returns error instead of failure, apply proper css to it too
Merged 4 years ago by frantisekz. Opened 4 years ago by frantisekz.
ci_error  into  master

file modified
+1 -1 
@@ -53,7 +53,7 @@ 
 

      return (
 

        <span className="badge badge-success">{result}</span>
 

      )
 

-   if (result.startsWith("fail"))
 

+   if (result.startsWith("fail") || (result.startsWith("error")))
 

    return (
 

      <span className="badge badge-danger">{result}</span>
 

    )

no initial comment

lgtm

Pull-Request has been merged by frantisekz
4 years ago

Not that technically error and failure have different meaning, but I agree they should both be red.
Metadata
None
No Tags
Changes Summary 1
+1 -1
file changed
src/components/WidgetItemPR.js
Powered by Pagure 5.14.1
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.