PR#56: Catch RHBZ #1314991 and handle it, with a soft failure - fedora-qa/os-autoinst-distri-fedora

fedora-qa / os-autoinst-distri-fedora

#56 Catch RHBZ #1314991 and handle it, with a soft failure

Merged 6 years ago by adamwill. Opened 6 years ago by adamwill.

rhbz1314991 into master

Catch RHBZ #1314991 and handle it, with a soft failure

Adam Williamson • 6 years ago

99a203b

needles/gnome/desktop_package_tool_update_bz1314991.json

file added

+16

		`@@ -0,0 +1,16 @@`
		`+ {`
		`+ "tags": [`
		`+ "DESKTOP-gnome",`
		`+ "desktop_package_tool_update_bz1314991"`
		`+ ],`
		`+ "properties": [],`
		`+ "area": [`
		`+ {`
		`+ "xpos": 455,`
		`+ "ypos": 344,`
		`+ "width": 114,`
		`+ "height": 114,`
		`+ "type": "match"`
		`+ }`
		`+ ]`
		`+ }`
		`\ No newline at end of file`

needles/gnome/desktop_package_tool_update_bz1314991.png

file added

empty or binary file added

tests/desktop_update_graphical.pm

file modified

+10 -2

		`@@ -41,8 +41,16 @@`
		`assert_and_click 'desktop_package_tool_update';`
		`# refresh updates`
		`assert_and_click 'desktop_package_tool_update_refresh', '', 120;`
		`- # wait for refresh, then apply updates`
		`- for my $n (1..5) {`
		`+ # wait for refresh, then apply updates, using a C-style loop so we`
		`+ # can reset it if needed due to RHBZ #1314991`
		`+ for (my $n = 1; $n < 6; $n++) {`
		`+ # Check if we see the 'cancelled by user action' error we get`
		`+ # when #1314991 happens, if so, refresh and restart the loop`
		`+ if (check_screen 'desktop_package_tool_update_bz1314991', 1) {`
		`+ record_soft_failure "RHBZ #1314991 (background PK operation interfered with update)";`
		`+ assert_and_click 'desktop_package_tool_update_refresh';`
		`+ $n = 1;`
		`+ }`
		`last if (check_screen 'desktop_package_tool_update_apply', 120);`
		`mouse_set 10, 10;`
		`mouse_hide;`

adamwill commented 6 years ago

We can deal with this annoying bug by looking out for the error
we see when it happens, hitting the 'refresh' button again, and
resetting the loop counter to 1 (requires changing the loop to
a C-style loop).

adamwill commented 6 years ago

Note: this is currently deployed on staging, so we can keep an eye out and see if it works there. @pschindl

adamwill commented 6 years ago

This works:

https://openqa.stg.fedoraproject.org/tests/155576

So I'm merging it now, cos it'd be really nice to have this fixed.

Pull-Request has been merged by adamwill

6 years ago