cda0d0b
@@ -0,0 +1,15 @@
+ {
+ "area": [
+ "xpos": 543,
+ "ypos": 227,
+ "width": 56,
+ "height": 15,
+ "type": "match"
+ }
+ ],
+ "properties": [],
+ "tags": [
+ "eog_about_credits"
+ ]
\ No newline at end of file
+ "height": 94,
+ "type": "match",
+ "width": 135,
+ "xpos": 444,
+ "ypos": 340
+ "eog_about_shown"
+ "ypos": 416,
+ "height": 57,
+ "xpos": 464,
+ "width": 149,
+ "eog_credits_shown"
+ "ypos": 413,
+ "width": 71,
+ "xpos": 330,
+ "ypos": 157
+ "eog_file_select_jpg"
+ "xpos": 863,
+ "ypos": 11,
+ "width": 153,
+ "height": 65,
+ "eog_fullscreen_on"
+ "xpos": 862,
+ "ypos": 165,
+ "width": 98,
+ "height": 19,
+ "eog_gallery_show"
+ "xpos": 103,
+ "ypos": 685,
+ "width": 133,
+ "height": 26,
+ "eog_gallery_shown"
+ "xpos": 518,
+ "ypos": 454,
+ "width": 53,
+ "height": 22,
+ "eog_help_image_zoom"
+ "eog_help_shown"
+ "xpos": 39,
+ "ypos": 106,
+ "width": 267,
+ "height": 45,
+ "xpos": 3,
+ "ypos": 125,
+ "width": 107,
+ "height": 38,
+ "eog_help_zoom_shown"
+ "ypos": 7,
+ "height": 91,
+ "xpos": 14
+ "eog_image_background"
+ "xpos": 515,
+ "ypos": 469,
+ "width": 183,
+ "height": 117,
+ "eog_image_default"
+ "xpos": 403,
+ "ypos": 355,
+ "width": 155,
+ "height": 95,
+ "eog_image_next"
+ "xpos": 414,
+ "ypos": 279,
+ "width": 145,
+ "height": 98,
+ "eog_image_rotated_left"
+ "xpos": 46,
+ "ypos": 39,
+ "width": 67,
+ "height": 29,
+ "eog_image_shown_increased"
+ "width": 214,
+ "height": 272,
+ "ypos": 92,
+ "xpos": 807
+ "eog_img_info"
+ "xpos": 816,
+ "ypos": 91,
+ "width": 205,
+ "height": 285,
+ "ypos": 464,
+ "width": 82,
+ "height": 14,
+ "eog_menu_about"
+ "xpos": 475,
+ "ypos": 47,
+ "width": 75,
+ "height": 21,
+ "eog_picture_name"
+ "ypos": 253,
+ "width": 114,
+ "height": 17,
+ "eog_set_wallpaper"
@@ -0,0 +1,22 @@
+ "xpos": 106,
+ "ypos": 137,
+ "width": 124,
+ },
+ "xpos": 568,
+ "ypos": 138,
+ "width": 62,
+ "eog_shortcuts_alt_shown"
+ "eog_shortcuts_shown"
+ "xpos": 107,
+ "ypos": 132,
+ "width": 63,
+ "xpos": 640,
+ "ypos": 134,
+ "width": 46,
+ "xpos": 793,
+ "ypos": 93,
+ "width": 162,
+ "eog_side_panel"
+ "xpos": 860,
+ "ypos": 350,
+ "width": 43,
+ "eog_submenu_show"
+ "xpos": 696,
+ "ypos": 123,
+ "width": 26,
+ "gnome_burger_menu"
+ "xpos": 959,
+ "ypos": 48,
+ "height": 16,
+ "width": 42,
+ "gnome_button_open"
+ "xpos": 11,
+ "ypos": 283,
+ "width": 20,
+ "gnome_dirs_pictures"
@@ -993,6 +993,21 @@
"START_AFTER_TEST": "%DEPLOY_UPLOAD_TEST%"
}
},
+ "eog": {
+ "profiles": {
+ "fedora-Silverblue-dvd_ostree-iso-ppc64le-*-ppc64le": 50,
+ "fedora-Silverblue-dvd_ostree-iso-x86_64-*-64bit": 50,
+ "fedora-Workstation-live-iso-ppc64le-*-ppc64le": 20,
+ "fedora-Workstation-live-iso-x86_64-*-64bit": 20,
+ "fedora-Workstation-raw_xz-raw.xz-aarch64-*-aarch64": 22
+ "settings": {
+ "BOOTFROM": "c",
+ "HDD_1": "disk_%FLAVOR%_%MACHINE%.qcow2",
+ "POSTINSTALL_PATH": "tests/applications/eog",
+ "START_AFTER_TEST": "%DEPLOY_UPLOAD_TEST%"
"desktop_update_graphical": {
"profiles": {
"fedora-KDE-live-iso-x86_64-*-64bit": 32,
@@ -0,0 +1,52 @@
+ use base "installedtest";
+ use strict;
+ use testapi;
+ use utils;
+
+ # This script will download the test data for evince, start the application,
+ # and set a milestone as a starting point for the other EoG tests.
+ sub run {
+ my $self = shift;
+ # Switch to console
+ $self->root_console(tty=>3);
+ # Perform git test
+ check_and_install_git();
+ # Download the test data
+ download_testdata("eog", "Pictures");
+ # Exit the terminal
+ desktop_vt;
+ # Start the application
+ menu_launch_type("image viewer");
+ # Check that is started
+ assert_screen 'apps_run_imageviewer';
+ # Fullsize the EoG window.
+ send_key("super-up");
+ # Open the test file to create a starting point for the other EoG tests.
+ send_key("ctrl-o");
+ if (get_var("CANNED") && !check_screen("gnome_dirs_pictures")) {
+ # open the Pictures folder.
+ assert_and_click("gnome_dirs_pictures", button => "left", timeout => 30);
+ # Select the image.jpg file.
+ assert_and_click("eog_file_select_jpg", button => "left", timeout => 30);
+ # Hit enter to open it.
+ send_key("ret");
+ # Check that the file has been successfully opened.
+ assert_screen("eog_image_default");
+ sub test_flags {
+ return {fatal => 1, milestone => 1};
+ 1;
+ # vim: set sw=4 et:
@@ -0,0 +1,27 @@
+ # This part tests if EoG can show the About window.
+ # Open the menu
+ send_key("f10");
+ # Click on the About item
+ assert_and_click("eog_menu_about");
+ assert_screen("eog_about_shown");
+ # Click on Credits
+ assert_and_click("eog_about_credits");
+ assert_screen("eog_credits_shown");
+ return {always_rollback => 1};
@@ -0,0 +1,30 @@
+ # This part tests if the application basic layout shows basic info.
+ # Check that the picture name is shown
+ assert_screen "eog_picture_name";
+ # Check that the Side panel is visible, try to make it visible if it is not.
+ if (!check_screen("eog_side_panel")) {
+ send_key("f9");
+ assert_screen("eog_side_panel");
+ # Check that info on side panel is correct
+ assert_screen("eog_img_info");
@@ -0,0 +1,25 @@
+ # This part tests if the application can navigate through the current folder.
+ # Go to next picture.
+ send_key("right");
+ assert_screen("eog_image_next");
+ # Go to previous picture
+ send_key("left");
+ assert_and_click("eog_image_default");
@@ -0,0 +1,28 @@
+ # This part tests if the application can be switched to full screen.
+ # Toggle full screen
+ send_key("f11");
+ wait_still_screen 2;
+ assert_screen("eog_fullscreen_on");
+ # Return to normal mode
@@ -0,0 +1,26 @@
+ # This part tests if the application can show help.
+ sleep 2;
+ # Open the shortcuts
+ send_key("f1");
+ assert_screen("eog_help_shown");
+ # Try another screen
+ assert_and_click("eog_help_image_zoom");
+ assert_screen("eog_help_zoom_shown");
@@ -0,0 +1,32 @@
+ # This part tests if the application can put an image as a wallpaper.
+ # Go to the menu
+ # Set as background
+ assert_and_click("eog_set_wallpaper");
+ # Confirm
+ send_key("tab");
+ # Close the application
+ send_key("ctrl-q");
+ # Check that the wallpaper was set
+ assert_screen("eog_image_background");
+ # This part tests if the application can rotate the displayed picture.
+ # Rotate left
+ send_key("shift-ctrl-r");
+ assert_screen("eog_image_rotated_left");
+ # Rotate right
+ send_key("ctrl-r");
@@ -0,0 +1,38 @@
+ # This part tests if the application can save the image as a different file.
+ # Shift-ctrl-S to save a file as a new file.
+ send_key("shift-ctrl-s");
+ # Type the new name, this should be possible without any intervention.
+ type_very_safely("new_image");
+ # Hit enter to confirm
+ wait_still_screen("2");
+ # Go to console
+ # List the location
+ assert_script_run("ls /home/test/Pictures/");
+ # Compare the files
+ assert_script_run("diff /home/test/Pictures/image.jpg /home/test/Pictures/new_image.jpg");
+ # This part tests if the application can show the shortcuts.
+ send_key("ctrl-?");
+ assert_screen("eog_shortcuts_shown");
+ assert_screen("eog_shortcuts_alt_shown");
@@ -0,0 +1,33 @@
+ # This part tests if the application can show the image gallery.
+ # Show the image gallery.
+ send_key("ctrl-f9");
+ unless (check_screen("eog_gallery_shown")) {
+ record_soft_failure("Key combo does not work, issue https://gitlab.gnome.org/GNOME/gtk/-/issues/4171");
+ # Open Submenu Show
+ assert_and_click("eog_submenu_show");
+ # Toggle gallery
+ assert_and_click("eog_gallery_show");
+ assert_screen("eog_gallery_shown");
+ # This part tests if the application can change the zoom for the displayed picture.
+ # Make the image size 1:1
+ send_key("1");
+ assert_screen("eog_image_shown_increased");
+ # Return to the best fit
+ send_key("f");
This bring a batch of tests for Image Viewer (Eye of Gnome).
Build succeeded.
Several test files (help.pm, saveas.pm, shortcuts.pm) aren't in the test subdirectory, but just at the top level of the tree. That's not right. saveas.pm seems to be a dupe of save_as.pm which is in the right place; the other two don't seem to be dupes at a quick glance.
help.pm
saveas.pm
shortcuts.pm
save_as.pm
you could probably get away with just "eog" here, that works on my system. The less we have to type the safer and faster.
not the Documents folder. :D
image.jpg?
Aside from the above notes this looks fine, thanks!
Not on Silverblue. eog does not work there. Don't know whether this is a bug or not, but image viewer works on both Workstation and Silverblue.
eog
image viewer
1 new commit added
Move the test files to a correct location.
Hah, so this is where the saveas.pm disappeared. I moved all the files back into the correct directory and deleted the duplication.
Fix the comments.
rebased onto afeb9e4d5d5b647aa78dd6c547095e23127dbf78
rebased onto b825a3fbe9b37a9f633afd03ac6deb7804c7eeed
you could probably get away with just "eog" here, that works on my system. The less we have to type the safer and faster. Not on Silverblue. eog does not work there. Don't know whether this is a bug or not, but image viewer works on both Workstation and Silverblue.
Huh, that's interesting! I don't know whether it's a bug either. Probably somehow the metadata is slightly different between the two cases.
rebased onto 7844fd89e73736ab94ac9563429a20d57d5d0d0e
OK, I've rebased this and deployed it on lab just to check it's OK, will merge if it looks alright on the next run.
rebased onto 9a2de4b5341cafb3dad841e33ea22ab5948afb53
rebased onto 8f151efa372909bd5e04e70123abdd8e12f9d588
rebased onto f152585167b33283c32b1eeb9dd30986c845b588
rebased onto c5e40c527a0b2f329c8943b31c7bf79254895831
so, uh, the eog_help_shown and eog_shortcuts_shown needles seem to be entirely missing.
eog_help_shown
eog_shortcuts_shown
Add missing needles.
rebased onto dae54efb86285e3a04c893fdc66786e99407c95a
2 new commits added
Create a test suite for EoG (Image Viewer)
rebased onto e3862f0f40b8ef2f019a9d367b4c245ff3ab9d7c
So, there were more needles missing, I must have forgotten to move them into the commit. I have tested the procedure in Staging and it works.
rebased onto ea4cb89ca6e5eb37668246ce2a8e66956d0cc56c
rebased onto 887df7eefb6badffceef9cfbf594ddb18e9ca111
rebased onto d79bd60047edf50292821667d4d512a9b9720497
rebased onto 9fbce6f1982af8b5b1078efff8899b0d8f3553f3
rebased onto 3957724e6a8fa6c55f522167a1d9616bfd7dc178
It looks like Zuul is unable to find the related requested node to run jobs (we did some cleaning on images). Could you update the .zuul.yaml to set the nodeset to fedora-34-vm or fedora-35-vm ?
Thanks for the catch, will do. It'd be nice if there were some convenience aliases or something in Zuul so we don't have to constantly update the version numbers for Fedora releases, Python versions...but I'm not sure how practical that is.
rebased onto aca49c9f6df034f2756dfa2f785bba603c5e282c
rebased onto 2e45535780fd119bacb44f4f12a17cd5b877f567
Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
@fbo the errors in the perl test are all things you'd expect if os-autoinst wasn't installed, but ci/perl.yaml lists it in the Install required package step. The test logs just show this for that step:
ci/perl.yaml
Install required package
2021-11-12 20:28:33.583981 | TASK [Install required packages] 2021-11-12 20:30:37.197966 | cloud-host | changed
which...doesn't help us much. Any way we can figure out what's going on there?
Oh, never mind, I see the problem...files moved.
rebased onto b7c0b390ddc3375d3fcf77f555e6cde1d5bd392c
rebased onto f12d1bcf9ab4c759ef5ab048a61c157c84ac3b5d
rebased onto a4f85a589033d5809c81757bcd897543f9a081d2
rebased onto 958b8aa04e6ec17c9a166a5808e93f71a9acb6d7
rebased onto 30edb5a6d9d392c064bd4441e721d49e88914f1f
rebased onto cda0d0b
I updated the needles on this a bit to make the tests pass on the most recent Rawhide. Merging, thanks.
Pull-Request has been merged by adamwill
This bring a batch of tests for Image Viewer (Eye of Gnome).