#237 Introduce a resize check and a postinstall test.
Merged 2 years ago by adamwill. Opened 2 years ago by lruzicka.

@@ -0,0 +1,15 @@ 

+ {

+   "properties": [],

+   "tags": [

+     "device_root_resized_thirteen"

+   ],

+   "area": [

+     {

+       "xpos": 411,

+       "ypos": 321,

+       "width": 98,

+       "height": 19,

+       "type": "match"

+     }

+   ]

+ } 

\ No newline at end of file

@@ -0,0 +1,15 @@ 

+ {

+   "properties": [],

+   "tags": [

+     "device_root_resized_thirteen"

+   ],

+   "area": [

+     {

+       "xpos": 394,

+       "ypos": 147,

+       "width": 74,

+       "height": 22,

+       "type": "match"

+     }

+   ]

+ } 

\ No newline at end of file

file modified
+1
@@ -802,6 +802,7 @@ 

                  "PARTITIONING": "custom_blivet_resize_lvm",

                  "HDD_1": "disk_%FLAVOR%_%MACHINE%.qcow2",

                  "INSTALL": "1",

+                 "POSTINSTALL": "custom_resize_lvm_postinstall",

                  "ROOT_PASSWORD": "weakpassword",

                  "START_AFTER_TEST": "install_lvm_ext4"

              }

@@ -60,6 +60,8 @@ 

      activate("root");

      custom_blivet_resize_partition(size => '13', units => 'GiB');

      wait_still_screen 5;

+     # Check that the partition has been correctly resized to 13G.

+     assert_screen "device_root_resized_thirteen";

  

      # Now format the resized root partition. It seems that the focus returns to the first

      # partition in the view, so we need to activate this again before we attempt to do 

@@ -62,6 +62,8 @@ 

      assert_and_click "anaconda_part_update_settings";

      # give it a second or two to update

      wait_still_screen 2;

+     # Check that the partition has been resized for 13GiB

+     assert_screen "device_root_resized_thirteen";

  

      # Add new /home partition into the emptied space.

      assert_and_click "anaconda_part_add";

@@ -0,0 +1,18 @@ 

+ use base "installedtest";

+ use strict;

+ use testapi;

+ 

+ sub run {

+     assert_screen "root_console";

+     # check that there is a root partition and that it has

+     # the correct size -> 13G

+     assert_script_run "lsblk | grep root | grep '13G'";

+ }

+ 

+ sub test_flags {

+     return { fatal => 1 };

+ }

+ 

+ 1;

+ 

+ # vim: set sw=4 et:

rebased onto c127abb4aa139c58533ca03474fe9729e0432957

2 years ago

that's not what this does. the curse of the copy/pasted comment strikes again :D

other than that, looks fine. thanks

oh, also, it would be nice to do custom_blivet_resize_lvm as well.

that's not what this does. the curse of the copy/pasted comment strikes again :D

Shoot!!! Yeah, my house seems to be haunted and these ghosts would come up over and over again.

By custom_blivet_resize_lvm you mean that such postinstall test should be there too?

rebased onto fb7e3cf1bcb461beac4eaa04ed89c0736cd3b7a8

2 years ago

By custom_blivet_resize_lvm you mean that such postinstall test should be there too?

Or that it also should assert the creation in the test?

Build succeeded.

I mean both, I guess, since we did both for non-blivet? Logically speaking since they're essentially the same test for the two custom UIs, they're both subject to the same potential issue and we should do the same checks for both.

If you'd rather make that a separate PR, though, I'm fine with merging this first.

2 new commits added

  • Add resize postinstall test to the bliver resize test.
  • Add check for correct partition size.
2 years ago

1 new commit added

  • Add needle to support the resize check.
2 years ago

rebased onto 318ae90dbb8d34b3595f2085b016362364b989bf

2 years ago

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

rebased onto fb49b042436bc5d02df3bd8bc31ec900f8d7842f

2 years ago

rebased onto 1810e38cee3d5a08a5e81f785edc3ee39b0976f6

2 years ago

Hey @adamwill, no need to create another PR for this. I have put everything into this one and I my tests are passing. :)

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

looks pretty good. can you try just force-pushing it to retrigger the tests in the morning and see if they work this time? thanks!

rebased onto 6d1d549

2 years ago

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci

Unfortunately, the Zuul died again, when I had been waiting for the result for several hours. Is Zuul one of our services? Or who is to be informed about it?

it's part of https://www.softwarefactory-project.io/ . It's run by RHers. I'll see if I can find someone to poke about it.

Build succeeded.

The NODE_FAILURE are happening because our cloud provider is experiencing network issues, resulting in zuul not able to create node.

@tdecacqu thanks for the info. anywhere we can follow status on that issue?

Pull-Request has been merged by adamwill

2 years ago

@tdecacqu thanks for the info. anywhere we can follow status on that issue?

It's private cloud by Vexxhost for RDO project, it does not have public monitoring, you can ping us in https://app.element.io/#/room/#sf-ops:matrix.org or internal IRC #rhos-ops