#123 typo in lib/utils.pm
Merged 4 years ago by lruzicka. Opened 4 years ago by michelmno.
fedora-qa/ michelmno/os-autoinst-distri-fedora typo_in_utils  into  master

typo in lib/utils.pm
Michel Normand • 4 years ago  
file modified
+2 -2
@@ -349,7 +349,7 @@ 

      # have not been updated, and the infra repo is rejected as its

      # metadata checksum isn't known to MM

      my $files = shift;

-     my $files ||= "/etc/yum.repos.d/fedora*.repo";

+     $files ||= "/etc/yum.repos.d/fedora*.repo";

      assert_script_run "sed -i -e 's,metalink,mirrorlist,g' ${files}";

  }

  
@@ -980,7 +980,7 @@ 

  

      my $beta = get_var('ISO');

      # install_pxeboot tests have ISO blanked, so we must use ISO_URL

-     my $beta ||= get_var('ISO_URL');

+     $beta ||= get_var('ISO_URL');

      my $nightly = get_var('BUILD');

      my $version = get_var('VERSION');

      my $development = get_var('DEVELOPMENT');

reported in autoinst-log.txt

"my" variable $files masks earlier declaration in same scope at /var/lib/openqa/share/tests/fedora/lib/utils.pm line 352.
"my" variable $beta masks earlier declaration in same scope at /var/lib/openqa/share/tests/fedora/lib/utils.pm line 995.

Thank you for this catch.

Pull-Request has been merged by lruzicka

4 years ago
Metadata