#87 Update app start/stop test for removal of 'app menu' from overview
Closed: Fixed 5 years ago by adamwill. Opened 5 years ago by adamwill.

@lruzicka so, you know how that huge app start/stop test you just wrote relies on using the presence of the 'app menu' in the top bar to check that an application is running?

...yeah, they took that out. That's (mostly) why the test fails completely in current Rawhide (there are also a couple other issues in there).

We will likely need to retool the test somehow to use some other indicator for whether the app is running, though @aday says "adamw, you might want to wait before changing it. we haven't 100% made up our minds on that change".


Metadata Update from @adamwill:
- Issue assigned to lruzicka
- Issue priority set to: High (was: Normal)
- Issue tagged with: bug

5 years ago

...yeah, they took that out

We're all on the same team here.

This change is part of a long-planned initiative, which has been well-publicised - see https://gitlab.gnome.org/GNOME/Initiatives/issues/4 and https://blogs.gnome.org/aday/2018/10/09/farewell-application-menus/ .

We will likely need to retool the test somehow to use some other indicator for whether the app is running, though @aday says "adamw, you might want to wait before changing it. we haven't 100% made up our minds on that change".

GNOME 3.32 is still a number of weeks away from UI freeze and we've been considering an alternative UI to what you see in rawhide. I'm hoping that we'll be able to make a final decision in the next few days and will keep you updated.

Yeah, things like that happen in the most interesting times. :crocodile:. I will take a look next week, if there is an easy and clever way to check for a running application that is not based on the bar item.
Also, there seems to be a new icon for Utilities, so those tests are failing, too.
Thanks for letting me know, Adam.

I have fixed this problem with a PR #88, see that for more details.

Apologies for not updating this ticket sooner - it took longer to resolve this question than anticipated.

The app menu has been reinstated upstream and should be visible in the top bar in the latest development version of gnome-shell. This is the latest merge: https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/389

@aday, I do not understand .... will there BE or NOT BE a application menu present in Gnome? According to your last comment, it seems to me, that the removal of the application menu was withdrawn.

@aday, I do not understand .... will there BE or NOT BE a application menu present in Gnome?

How very Shakespearean. :)

According to your last comment, it seems to me, that the removal of the application menu was withdrawn.

The application menu will continue to be present - the application icon and name will continue to be shown in the top bar.

What has changed is the content of the menu.

Ok, thanks for the info. Have a nice time. :wine_glass:

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #88 Merged 5 years ago