#32 Change openQA updates image effect (current one no longer works)
Closed: Fixed None Opened 8 years ago by adamwill.

The updates image we use for testing updates in openQA at present tries to change the emblem that's applied to the disk icon in the INSTALLATION DESTINATION screen when a disk is selected as an install target.

Unfortunately, since https://github.com/rhinstaller/anaconda/commit/21f3f52374dab21bb21f798d0130222725446f2e , this won't work any more, because the emblem is no longer a file we can handily override with an updates image, it's in a GTK+ resource bundle. This change is now live in f24 and Rawhide, so the updates tests are all broken.

We can try to keep the current approach working but replace the resource bundle (I'm not sure how viable that is as I've no idea how GTK+ resource bundles work), or we can change what the updates image does instead. davidshea suggests that it's easy to change the color of some text - e.g. by putting a file /run/install/updates/anaconda-gtk.css in an updates image with this content:

#anaconda-disk-description {
    color: purple;
}

the text of the disk identifier in that same widget becomes purple instead of black. Apparently we can use the same basic approach to change the background color of something, or anything else that's done with CSS styling in anaconda. So we just need to try and come up with something that's as unlikely as possible to change in future (and something that's isolated to one spot which we hit in all updates image tests).

Anyone wanna take this? It'll involve rebuilding the updates image and adjusting the tests appropriately. So long as the new updates image is in the same place as the old one we can easily regenerate the hard disk image that includes the updates image.


This ticket had assigned some Differential requests:
D799
D800

D799 and D800 together should address this.

This can be closed now?

Btw, I used [[ https://fedorapeople.org/groups/qa/updates/updates-openqa.img | the new image ]] to update the manual test case as well:
https://fedoraproject.org/wiki/QA:Testcase_Anaconda_updates.img_via_URL

Thanks for creating it.

Probably, but we haven't actually had a working image for f24 or Rawhide to test since the change landed, so I was waiting on that before closing.

OK, https://openqa.fedoraproject.org/tests/12245 shows this is working (I had to go in and load the templates manually for tedious reasons, which is why previous recent runs still failed) so we can close this.

Login to comment on this ticket.

Metadata