b557823 Don't check version or pre-release note on banners

Authored and Committed by adamwill 4 years ago
26 files changed. 11 lines added. 195 lines removed.
needles/anaconda/identification/arabic/prerelease_note-arabic-rtl-server-orange-20190911.json
file removed
-16
needles/anaconda/identification/arabic/prerelease_note-arabic-rtl-server-orange-20190911.png
file removed
-0
needles/anaconda/identification/french/prerelease_note-french-blue-20190911.json
file removed
-16
needles/anaconda/identification/french/prerelease_note-french-blue-20190911.png
file removed
-0
needles/anaconda/identification/japanese/prerelease_note-japanese-generic-blue-20190828.json
file removed
-16
needles/anaconda/identification/japanese/prerelease_note-japanese-generic-blue-20190828.png
file removed
-0
needles/anaconda/identification/japanese/prerelease_note-japanese-server-blue-20190911.json
file removed
-16
needles/anaconda/identification/japanese/prerelease_note-japanese-server-blue-20190911.png
file removed
-0
needles/anaconda/identification/prerelease_note_generic_blue.json
file removed
-15
needles/anaconda/identification/prerelease_note_generic_blue.png
file removed
-0
needles/anaconda/identification/prerelease_note_server_blue.json
file removed
-15
needles/anaconda/identification/prerelease_note_server_blue.png
file removed
-0
needles/anaconda/identification/prerelease_note_workstation_blue-20190829.json
file removed
-15
needles/anaconda/identification/prerelease_note_workstation_blue-20190829.png
file removed
-0
needles/anaconda/identification/version_29_blue.json
file removed
-15
needles/anaconda/identification/version_29_blue.png
file removed
-0
needles/anaconda/identification/version_30_blue.json
file removed
-15
needles/anaconda/identification/version_30_blue.png
file removed
-0
needles/anaconda/identification/version_31-rtl-orange.json
file removed
-15
needles/anaconda/identification/version_31-rtl-orange.png
file removed
-0
needles/anaconda/identification/version_31_blue.json
file removed
-15
needles/anaconda/identification/version_31_blue.png
file removed
-0
needles/anaconda/identification/version_rawhide_blue.json
file removed
-15
needles/anaconda/identification/version_rawhide_blue.png
file removed
-0
tests/_do_install_and_reboot.pm
file modified
+5 -1
tests/disk_guided_empty.pm
file modified
+6 -10
    Don't check version or pre-release note on banners
    
    This reduces the coverage of the identification test a bit but
    also *substantially* simplifies it. We run into a ton of problems
    when we try to check the version and prerelease text on screens
    where it appears on banners:
    
    * The banners differ between variants
    * The pre-release text is translated
    * The banners have gradients so for RTL languages, even if some
      text is untranslated (e.g. 'Fedora 31') it appears on a
      different background color than on LTR languages
    * The prerelease text is dark red; if it appears on a dark blue
      area of the banner this can trigger an os-autoinst needle
      comparison bug: https://progress.opensuse.org/issues/56822
    
    All of this together means we wind up continually fighting these
    checks and we have a whole forest of needles just for them, and
    it doesn't seem worthwhile. So let's drop all the places where
    we were checking version and prerelease on banners, and only
    check them in two places where they appear on a grey background,
    which avoids most of the problems (we just need one version
    needle per release, and one prerelease needle per language).
    
    Signed-off-by: Adam Williamson <awilliam@redhat.com>
    
        
file modified
+6 -10