From 3998e9c86cdfdb7a9956e89444676db960a8594c Mon Sep 17 00:00:00 2001 From: Adam Williamson Date: Jan 08 2020 23:32:29 +0000 Subject: Drop the 'cockpit join progress' needle match The text we used to get has been replaced with a spinner, which is difficult and unreliable to match on. This match was only here to make the test fail a bit faster if it was broken, so let's just live without it. Signed-off-by: Adam Williamson --- diff --git a/needles/cockpit/join_progress-20191129.json b/needles/cockpit/join_progress-20191129.json deleted file mode 100644 index edc8b77..0000000 --- a/needles/cockpit/join_progress-20191129.json +++ /dev/null @@ -1,15 +0,0 @@ -{ - "area": [ - { - "type": "match", - "width": 152, - "ypos": 497, - "xpos": 340, - "height": 14 - } - ], - "properties": [], - "tags": [ - "cockpit_join_progress" - ] -} \ No newline at end of file diff --git a/needles/cockpit/join_progress-20191129.png b/needles/cockpit/join_progress-20191129.png deleted file mode 100644 index a1642f0..0000000 Binary files a/needles/cockpit/join_progress-20191129.png and /dev/null differ diff --git a/needles/cockpit/join_progress-cockpit198.json b/needles/cockpit/join_progress-cockpit198.json deleted file mode 100644 index 229c51e..0000000 --- a/needles/cockpit/join_progress-cockpit198.json +++ /dev/null @@ -1,15 +0,0 @@ -{ - "area": [ - { - "xpos": 424, - "ypos": 477, - "height": 14, - "width": 152, - "type": "match" - } - ], - "properties": [], - "tags": [ - "cockpit_join_progress" - ] -} \ No newline at end of file diff --git a/needles/cockpit/join_progress-cockpit198.png b/needles/cockpit/join_progress-cockpit198.png deleted file mode 100644 index fc57586..0000000 Binary files a/needles/cockpit/join_progress-cockpit198.png and /dev/null differ diff --git a/needles/cockpit/join_progress.json b/needles/cockpit/join_progress.json deleted file mode 100644 index 8569bb5..0000000 --- a/needles/cockpit/join_progress.json +++ /dev/null @@ -1,15 +0,0 @@ -{ - "properties": [], - "area": [ - { - "xpos": 237, - "ypos": 461, - "width": 125, - "height": 14, - "type": "match" - } - ], - "tags": [ - "cockpit_join_progress" - ] -} \ No newline at end of file diff --git a/needles/cockpit/join_progress.png b/needles/cockpit/join_progress.png deleted file mode 100644 index 77df7b9..0000000 Binary files a/needles/cockpit/join_progress.png and /dev/null differ diff --git a/tests/realmd_join_cockpit.pm b/tests/realmd_join_cockpit.pm index a43eee7..0d557bc 100644 --- a/tests/realmd_join_cockpit.pm +++ b/tests/realmd_join_cockpit.pm @@ -50,9 +50,6 @@ sub run { type_string("monkeys123", 4); sleep 3; assert_and_click "cockpit_join_button"; - # check we hit the progress screen, so we fail faster if it's - # broken - assert_screen "cockpit_join_progress"; # join involves package installs, so it may take some time assert_screen "cockpit_join_complete", 300; # quit browser to return to console