21eea18 Add a needle check script, remove some unused needles

Authored and Committed by adamwill 4 years ago
67 files changed. 147 lines added. 505 lines removed.
check-needles.py
file added
+146
needles/anaconda/install_destination/reclaim_space_second_partition.json
file removed
-16
needles/anaconda/install_destination/reclaim_space_second_partition.png
file removed
-0
needles/anaconda/install_process/french/user_creation_password_input_french.json
file removed
-18
needles/anaconda/install_process/french/user_creation_password_input_french.png
file removed
-0
needles/anaconda/install_process/russian/user_creation_password_input_russian.json
file removed
-16
needles/anaconda/install_process/russian/user_creation_password_input_russian.png
file removed
-0
needles/anaconda/install_process/user_creation_password_input-cantarell21.json
file removed
-18
needles/anaconda/install_process/user_creation_password_input-cantarell21.png
file removed
-0
needles/anaconda/partitioning/add_mountpoint.json
file removed
-18
needles/anaconda/partitioning/add_mountpoint.png
file removed
-0
needles/anaconda/partitioning/desired_capacity.json
file removed
-18
needles/anaconda/partitioning/desired_capacity.png
file removed
-0
needles/anaconda/partitioning/list_box_boot.json
file removed
-17
needles/anaconda/partitioning/list_box_boot.png
file removed
-0
needles/anaconda/partitioning/list_box_button.json
file removed
-17
needles/anaconda/partitioning/list_box_button.png
file removed
-0
needles/anaconda/partitioning/list_box_root.json
file removed
-17
needles/anaconda/partitioning/list_box_root.png
file removed
-0
needles/anaconda/partitioning/list_box_swap.json
file removed
-17
needles/anaconda/partitioning/list_box_swap.png
file removed
-0
needles/anaconda/partitioning/plus_button.json
file removed
-17
needles/anaconda/partitioning/plus_button.png
file removed
-0
needles/anaconda/partitioning/scheme_lvm.json
file removed
-16
needles/anaconda/partitioning/scheme_lvm.png
file removed
-0
needles/cockpit/cockpit_updates_available.json
file removed
-15
needles/cockpit/cockpit_updates_available.png
file removed
-0
needles/cockpit/cockpit_updates_console_update.json
file removed
-15
needles/cockpit/cockpit_updates_console_update.png
file removed
-0
needles/cockpit/cockpit_updates_restart_confirm.json
file removed
-15
needles/cockpit/cockpit_updates_restart_confirm.png
file removed
-0
needles/gnome/apps/apps_first_services.png
file removed
-0
needles/gnome/apps/apps_menu_documents.json
file removed
-15
needles/gnome/apps/apps_menu_documents.png
file removed
-0
needles/gnome/apps/apps_menu_settings-20200316.json
file removed
-15
needles/gnome/apps/apps_menu_settings-20200316.png
file removed
-0
needles/gnome/apps/apps_menu_settings.json
file removed
-15
needles/gnome/apps/apps_menu_settings.png
file removed
-0
needles/gnome/apps/apps_menu_terminal-20190128.json
file removed
-15
needles/gnome/apps/apps_menu_terminal-20190128.png
file removed
-0
needles/gnome/apps/apps_menu_terminal-20200316.json
file removed
-15
needles/gnome/apps/apps_menu_terminal-20200316.png
file removed
-0
needles/gnome/apps/apps_menu_terminal.json
file removed
-15
needles/gnome/apps/apps_menu_terminal.png
file removed
-0
needles/gnome/apps/apps_run_clocks_access.json
file removed
-15
needles/gnome/apps/apps_run_clocks_access.png
file removed
-0
needles/gnome/apps/apps_run_documents.json
file removed
-15
needles/gnome/apps/apps_run_documents.png
file removed
-0
needles/gnome/apps/apps_run_nautilus.json
file removed
-15
needles/gnome/apps/apps_run_nautilus.png
file removed
-0
needles/gnome/apps/apps_run_settings.json
file removed
-15
needles/gnome/apps/apps_run_settings.png
file removed
-0
needles/gnome/apps/apps_run_weather_access.json
file removed
-15
needles/gnome/apps/apps_run_weather_access.png
file removed
-0
needles/gnome/apps/apps_sub_utilities.json
file removed
-15
needles/gnome/apps/apps_sub_utilities.png
file removed
-0
needles/gnome/apps/apps_utilities.json
file removed
-15
needles/gnome/apps/apps_utilities.png
file removed
-0
needles/kde/apps/firewall_requires.json
file removed
-15
needles/kde/apps/firewall_requires.png
file removed
-0
needles/kde/apps/kamoso_runs.json
file removed
-15
needles/kde/apps/kamoso_runs.png
file removed
-0
needles/kde/apps/menu_favorites.json
file removed
-15
needles/kde/apps/menu_favorites.png
file removed
-0
needles/kde/apps/users_runs.json
file removed
-15
needles/kde/apps/users_runs.png
file removed
-0
tox.ini
file modified
+1 -0
    Add a needle check script, remove some unused needles
    
    I call this...The @lruzicka Catcher!
    
    It's a script that checks for needles that aren't actually used
    anywhere. It also checks for cases where we have a needle JSON
    file but no image, or an image file but no JSON file (and wipes
    one case of the latter). It also adds a run of the script to tox
    so we get it in CI.
    
    You could make this script a lot more elaborate if you like, by
    being fancier about parsing the test code and templates, but I
    don't think it's really warranted, I think it just needs to be
    'good enough'. It's not the end of the world if it misses the
    odd thing or the whitelisting goes stale.
    
    Quite a lot of the removed needles are remnants of different
    approaches to app start/stop testing which weren't caught in the
    initial PR review. The short-name partitioning ones are odd; they
    were introduced in the commit that moved needles into subdirs,
    but at least some of them don't actually appear to be moves. They
    may have been non-tracked files Josef had lying around that got
    into the commit by mistake, or they may just be old needles we
    really used at some point but aren't using any more.
    reclaim_space_second_partition was introduced as part of the
    shrink test (along with reclaim_space_first_partition) but was
    never actually used by that test - I guess, again, the test got
    re-written during review but we forgot to remove the needle. We
    rejigged user creation to use tab presses not a needle match a
    while back, which made user_creation_password_input unnecessary.
    The various cockpit_updates_* needles are I think remnants of
    rewrites of the cockpit update tests that again were missed in
    PR review, the tests as merged never used them.
    
    Signed-off-by: Adam Williamson <awilliam@redhat.com>
    
        
file added
+146
file modified
+1 -0