#95 Let release_from_number accept both integers and strings
Merged 3 years ago by frantisekz. Opened 3 years ago by frantisekz.

@@ -130,11 +130,12 @@ 

  

  def release_from_number(release_num):

      """

-     Returns release string (Fedora XX) from number

-     Returns "Fedora Rawhide" if release number is equal to Rawhide number

+     Returns release string (Fedora XX) from number (or "rawhide" string)

+     Returns "Fedora Rawhide" if release number is equal to Rawhide number or "rawhide"

      """

      releases = CACHE.get("fedora_releases")

-     if release_num.lower() == "rawhide" or release_num == releases["rawhide"]:

+ 

+     if str(release_num).lower() == "rawhide" or int(release_num) == releases["rawhide"]:

          return "Fedora Rawhide"

      if int(release_num) in app.config["EPEL_RELEASES"] or int(release_num) <= 6:

          return "EPEL %s" % release_num

Fixes passing rawhide number which didn't work either way.

It either crashed on calling lower on int, or didn't match rawhide (got str "34", compared to int 34).

This way, it should work anytime.

Obligatory, found out while working on unit tests :)

Pull-Request has been merged by frantisekz

3 years ago
Metadata