#75 Fedora Health Check might be missing Branched Data, don't crash too bad on it
Merged 3 years ago by frantisekz. Opened 3 years ago by frantisekz.

file modified
+10 -3
@@ -716,9 +716,16 @@ 

      releases = CACHE.get('fedora_releases')["values"]

      for release in releases[:-1]: # Process every release but rawhide

          release = str(release)

-         data[release] = process_health_check_json(get_json(app.config["HEALTH_CHECK_URL"] + release))

-         data[release + "-testing"] = process_health_check_json(get_json(app.config["HEALTH_CHECK_URL"] + release + "-testing"))

-     data["rawhide"] = process_health_check_json(get_json(app.config["HEALTH_CHECK_URL"] + "rawhide"))

+         # Remote resource might not have data for some Fedora Release, typically branched right after branching point

+         try:

+             data[release] = process_health_check_json(get_json(app.config["HEALTH_CHECK_URL"] + release))

+             data[release + "-testing"] = process_health_check_json(get_json(app.config["HEALTH_CHECK_URL"] + release + "-testing"))

+         except TypeError:

+             pass

+     try:

+         data["rawhide"] = process_health_check_json(get_json(app.config["HEALTH_CHECK_URL"] + "rawhide"))

+     except TypeError:

+         pass

      return data

  

  def get_repo_for_health_check(release):

no initial comment

Y U no have try-except block here too?

rebased onto f8bd9aa

3 years ago

Me now has moar try blocks over der.

Pull-Request has been merged by frantisekz

3 years ago
Metadata