#59 several warning console and terminal warning removed
Closed 2 years ago by lbrabec. Opened 3 years ago by kunalprakash1309.
fedora-qa/ kunalprakash1309/landingpage fix-bug  into  master

file modified
+1 -1
@@ -23,7 +23,7 @@ 

          }>

          {this.props.children}

          <a

-           href="#"

+           href="##"

            className={this.props.config_mode ? "d-block text-center badge badge-primary" : "d-none"}

            onClick={(e) => this.props.toggle_handler(e, this.props.component_name)}

            role="button">

@@ -75,9 +75,9 @@ 

        2

      )

      components = components.map((row) => (

-       <Row>

+       <Row key={row} >

          {row.map((item) => (

-           <div className="col-md-6">

+           <div key={item} className="col-md-6">

              <Hideable

                config_mode={this.state.config_mode}

                toggle_handler={this.toggle_component_visibility.bind(this)}
@@ -105,7 +105,7 @@ 

            <Row className="padded">

              <div className="col-md-12 text-right">

                <a

-                 href="#"

+                 href="##"

                  onClick={(e) => this.toggle_config_mode(e)}

                  className="badge badge-secondary events"

                  role="button">

file modified
+1 -1
@@ -16,7 +16,7 @@ 

            </NavbarBrand>

            {this.props.loading ? (

              <span className="fa-lg">

-               <i class="fas fa-spinner fa-pulse"></i>

+               <i className="fas fa-spinner fa-pulse"></i>

              </span>

            ) : null}

          </Container>

@@ -388,7 +388,7 @@ 

  

      return (

        <div>

-         <a href="#" onClick={(e) => this.toggle(e)}>

+         <a href="##" onClick={(e) => this.toggle(e)}>

            {this.props.buttonLabel}

          </a>

          <Modal

file modified
+1 -1
@@ -30,7 +30,7 @@ 

      const id = _.uniqueId("collapsable-badge-id-")

      return (

        <span>

-         <a class={type + " " + type + "-" + expand_class} href="#" id={id} role="button">

+         <a class={type + " " + type + "-" + expand_class} href="##" id={id} role="button">

            {expand_text}

          </a>

          <UncontrolledCollapse toggler={"#" + id}>{children}</UncontrolledCollapse>

Several warnings are removed such as :-
- accessible warning in anchor tags
- class is provided instead of className
- unique keys are not given

Thanks for participating in contribution period of Outreachy. This pull-request has not been selected to be merged and will be closed for housecleaning purposes. We may revisit this pull-request later, but as of now we will focus on merging pull-requests from our accepted intern.

Pull-Request has been closed by lbrabec

2 years ago