#57 Warnings during compilation were removed from differnt files
Closed 2 years ago by lbrabec. Opened 2 years ago by gift_.
fedora-qa/ gift_/landingpage remove_warning_at_compilation  into  master

file modified
+1 -1
@@ -23,7 +23,7 @@ 

          }>

          {this.props.children}

          <a

-           href="#"

+           href="/#"

            className={this.props.config_mode ? "d-block text-center badge badge-primary" : "d-none"}

            onClick={(e) => this.props.toggle_handler(e, this.props.component_name)}

            role="button">

@@ -105,7 +105,7 @@ 

            <Row className="padded">

              <div className="col-md-12 text-right">

                <a

-                 href="#"

+                 href="/#"

                  onClick={(e) => this.toggle_config_mode(e)}

                  className="badge badge-secondary events"

                  role="button">

@@ -157,7 +157,7 @@ 

      }

  

      const testtype = extra_data.testtype

-     const tc_rawname = extra_data.display_name

+     // const tc_rawname = extra_data.display_name

  

      return (

        <ModalInfo buttonLabel={name}>
@@ -388,7 +388,7 @@ 

  

      return (

        <div>

-         <a href="#" onClick={(e) => this.toggle(e)}>

+         <a href="/#" onClick={(e) => this.toggle(e)}>

            {this.props.buttonLabel}

          </a>

          <Modal

file modified
+1 -1
@@ -30,7 +30,7 @@ 

      const id = _.uniqueId("collapsable-badge-id-")

      return (

        <span>

-         <a class={type + " " + type + "-" + expand_class} href="#" id={id} role="button">

+         <a class={type + " " + type + "-" + expand_class} href="/#" id={id} role="button">

            {expand_text}

          </a>

          <UncontrolledCollapse toggler={"#" + id}>{children}</UncontrolledCollapse>

Here's the link to the issue I worked on : https://pagure.io/fedora-qa/landingpage/issue/52
Warnings during compilation were removed by the following actions
1.The href attribute was modified in the following files Hideable.js in the landingpage folder
LandingPage.js in the landingpage folder
component.js in the wizard component
2. Unused var was removed in FedoraManualTesting.js in the wizard folder

Thanks for participating in contribution period of Outreachy. This pull-request has not been selected to be merged and will be closed for housecleaning purposes. We may revisit this pull-request later, but as of now we will focus on merging pull-requests from our accepted intern.

Pull-Request has been closed by lbrabec

2 years ago