@alisina92, This is already on https://pagure.io/fedora-qa/landingpage/pull-request/15
And also, Moving the code to two files/components doesn't remove redundancy.

Dear manishakanyal,

Thank you for your reply, how can I help you with this component? I know
about the frontend but I am not familiar with a backend.
@lbrabec@redhat.com lbrabec@redhat.com told me that I can work on any
ticket regardless of who is doing it.

Kind Regards,

Alisina Bolourchi

On Thu, 1 Apr 2021 at 13:03, Manisha Kanyal pagure@pagure.io wrote:

manishakanyal commented on the pull-request: Redundancy removed from Blockers that you are following:
@alisina92, This is already on https://pagure.io/fedora-qa/landingpage/pull-request/15 And also, Moving the code to two files/components doesn't remove redundancy.

To reply, visit the link below or just reply to this email
https://pagure.io/fedora-qa/landingpage/pull-request/26

no problem @alisina92.
But I don't see any message regarding this on the mailing list.
At most of the places, we do avoid working on something on which someone else is already working as it hinders the confidence of the one who's already working and also it makes do the same thing by multiple people.

Dear manishakanyal,
I know that we shouldn't work on the ticket that someone has picked up so
I asked @lbrabec@redhat.com lbrabec@redhat.com on the chat channel and
he said it wasn't said on the mailing list.

Kind Regards,

Alisina

On Thu, 1 Apr 2021 at 13:56, Manisha Kanyal pagure@pagure.io wrote:

manishakanyal commented on the pull-request: Redundancy removed from Blockers that you are following:
no problem @alisina92. But I don't see any message regarding this on the mailing list. At most of the places, we do avoid working on something on which someone else is already working as it hinders the confidence of the one who's already working and also it makes do the same thing by multiple people.

To reply, visit the link below or just reply to this email
https://pagure.io/fedora-qa/landingpage/pull-request/26

@alisina92 No issues! I would say give loaders one issue a try.

This change didn't reduce the redundancy of code at all. Instead of having the same code twice in src/landingpage/Blockers.js, now there is the same code in two separate files src/landingpage/BetaStats.js and src/landingpage/FinalStats.js. One general component for both beta and final stats is a way to go here.

Hi Brabec,

Thanks for your feedback I have another look.

Kind Regards,

Alisina

On Thu, 8 Apr 2021 at 10:20, Lukas Brabec pagure@pagure.io wrote:

lbrabec commented on the pull-request: Redundancy removed from Blockers
that you are following:
This change didn't reduce the redundancy of code at all. Instead of having the same code twice in `src/landingpage/Blockers.js`, now there is the same code in two separate files `src/landingpage/BetaStats.js` and `src/landingpage/FinalStats.js`. One general component for both beta and final stats is a way to go here.

To reply, visit the link below or just reply to this email
https://pagure.io/fedora-qa/landingpage/pull-request/26

Hi @lbrabec I have a new commit to be reviewed. thank you)

Thanks for participating in contribution period of Outreachy. This pull-request has not been selected to be merged and will be closed for housecleaning purposes. We may revisit this pull-request later, but as of now we will focus on merging pull-requests from our accepted intern.