#2 Make this translatable!
Opened 4 years ago by jskladan. Modified 3 years ago

After a chat on Flock, we decided this should be better!

@jibecfed helped!


Create a container, so one does not need to install all NPM mess, and people can run it localy

Hi, where is this content currently published?

Hey, @lbrabec may I know the status of this issue. Is it still open to working upon?
Can you describe this issue a bit more?

@divyanshisingh Yes, this is still unresolved. At the moment, all the strings are basically hard-coded, thus the project is virtually non-translatable. The gist here is using gettext (or another tool that is used for translations in Fedora, if any) and other tooling in order to extract the strings from the sources, and make it possible to create translations.

Ok sure, I would like to take this up, please assign me this issue @jskladan
I think using the react-translate-component will solve this issue. Can you please specify to me the languages in which you want the application can be translated as and when required by the user?
I am thinking of making a dropdown that will contain the list of languages in which our application can be translated.

hello @lbrabec and @jskladan can i do an initial pull request so that you check it and let me know if what am doing is what is expected?

hello @lbrabec and @jskladan , here is a link to my repo on translation. pls check it out and give me corrections
https://pagure.io/fork/queeniva/fedora-qa/landingpage/tree/translation
am not completely done working on it, thats why i did not create a pull request instead.

Looks good so far, thanks!

When you proceed to create PR, please include only commit(s):

  • 78fcd27 initial commit for my translation process
  • and other newer relevant commits

There are two commits that are not relevant to translation and shouldn't be in the upcoming PR:

  • aa4fd14 Changed Source Link component from Class based to funtional and also added icon and onpress props to Source link component
  • afced8d added how to generate your public ssh key on the README.md file

ok sir, thanks.
i will a create a PR when am done and remove all irrelevant commits

Good day sir @lbrabec and sir @jskladan , hope you all had a wonderful weekend. i have been having troubles while trying to translate the FedoraManualTesting page, its been giving me errors and am confused on how to proceed, pls i would like some help from you guys

Screen_Shot_2021-04-19_at_5.30.54_AM.png

The same process done on the other pages during translation is what is done to the FedoraManualTesting page , but it generates alot of errors, pls help , maybe some tips or an idea on how i can proceed.
Thanks Queeniva

thank you for the internationalization effort!

a few suggestion:

madatory: strings should be complete=2E blockers_and_FE lacks Fedora and i=
t's version number=2E Some languages need to change world order, others nee=
d to change the word Fedora itself (such as polish)=2E

Nice to have: please add a LINGUAS file containing the list of translated =
languages, and make your script take the list of languages from it (weblate=
will change it automatically)=2E Or find another way to prevent a team to=
have to resquest to add it's language=2E

Bonus: give a look to dates, plurals and right to left language=2E

Jean-Baptiste

Thank you soo much for the suggestions sir.

Good day sir @lbrabec and sir @jskladan , hope you all had a wonderful weekend. i have been having troubles while trying to translate the FedoraManualTesting page, its been giving me errors and am confused on how to proceed, pls i would like some help from you guys

Did you import the i18n?

Good day sir @lbrabec and sir @jskladan , hope you all had a wonderful weekend. i have been having troubles while trying to translate the FedoraManualTesting page, its been giving me errors and am confused on how to proceed, pls i would like some help from you guys

Did you import the i18n?

yes i did import it

Can you please push your changes so I can checkout your fork?

ok sir, lemme get to it

FedoraManualTestingItem does not have i18n in its props. It is likely caused by wrong usage of connect() as you are passing two components to it.

ohh yea your right.
i just corrected that, but still having errors.
can i put all the class components in FedoraManualTesting.js in separate files? so i will export and then import to FedoraManualTesting.js. i think this will make it easier to translate with no errors

i have translated every other file and i have also added a button to select the language you prefer, though just English and french for now

Hello everyone, i would love to ask for help on something.
i created my translation branch from one of my branches instead of creating it from the master branch, i already pushed my code. i want to do a PR but do not want the commits of the other branch appear in my PR, pls help, what can i do??

@queeniva Looking at your git and branches, there sadly is no "easy" way out of it, since the translation-related code changes some of the files changed by the aa4fd14 commit that is a part of the branch-changes you wanted to get rid of.

So to me, re-starting from scratch seems to be the least painful option. You could, obviously, run something like git rebase -i b743bed but then you'd need to solve quite a lot of merge conflicts by hand, and from my personal experince, that is not worth it with the changes you have in the translation branch anyway.

Also, I'm absolutely not a translation expert (maybe the opposite), but to me it looks like most of the https://pagure.io/fork/queeniva/fedora-qa/landingpage/c/78fcd275a452ab6ab51996c786fd107fe5c74856?branch=translation is auto-generated from some tool anyway (I mean, the code, not the translation to french you have later on), based on how some of the "old" text is mixed up with the parts marked for translation, and some of the text being missed completely (e.g. https://pagure.io/fork/queeniva/fedora-qa/landingpage/blob/78fcd275a452ab6ab51996c786fd107fe5c74856/f/src/wizard/FedoraEasyKarma.js#_64 and the lines around it). So this would need to get changed anyway.

I'm sorry I could not have provided an easier way of doing this, and you are most welcomed to go ahead and try resolving the merge conflicts by hand - it will be a valuable exercise of git usage - but my gut feeling is that it will take a lot more time than reimplementing the changes from a clean start.

hello @lbrabec , what i did was i created my translation branch from my source link branch, so the commits of the source link branch were added to my translation branch.

I had already gone far with my translation, so starting all over would take me a lot of time.
However, what i did was that i removed all the changes i did in the sourcelink branch from my translation branch and made the branch identical to my upstream which is the fedora landingpage https://pagure.io/fedora-qa/landingpage

Login to comment on this ticket.

Metadata
Attachments 1