if adamw finds it alright, @kparal can i go ahead and write the missing test cases you pointed?

Seems reasonable to me, yes. Please follow the same template use as the existing test cases (if any) when creating the new ones. Thanks.

Remember, Server does still use xfs-on-LVM by default, so we're still testing LVM there...

if adamw finds it alright, @kparal can i go ahead and write the missing test cases you pointed?

Great, but that's quite a load, and you're still finishing #638. What if you took e.g. the first two and the latter two could be created by someone else, possibly working in parallel?

@coremodule would you have time to help out with the latter two test cases?

We should ideally have this ready before Beta. (And it also helps with #628).

@kparal Yeah, I will take this bug, or the last two testcases anyway if @sumantrom still wants to do the first two.

https://fedoraproject.org/wiki/QA:Testcase_partitioning_blivet_standard_partition_ext4
https://fedoraproject.org/wiki/QA:Testcase_partitioning_custom_standard_partition_ext4

@kparal please review and once done, can hook these up to the matrix!
Also, @coremodule lemme know if you need any help :)

https://fedoraproject.org/wiki/QA:Testcase_partitioning_custom_lvm_ext4
https://fedoraproject.org/wiki/QA:Testcase_partitioning_blivet_lvm_ext4

See the above for the last two testcases. I am not 100% sure that the blivet testcase is correctly written as I don't often use/test blivet, so @sumantrom and @kparal to double check me there. If they look good, let's merge them!

https://fedoraproject.org/wiki/QA:Testcase_partitioning_custom_standard_partition_ext4

1) The associated criterion link is incorrect (also see below).
2) The step Change the File System drop-down to ext4, and click Update settings is a bit confusing, because the partition is already set as ext4 by default. So I'd use something like Check the File System field. If it is not set to ext4, change it to ext4 and click Update settings.

https://fedoraproject.org/wiki/QA:Testcase_partitioning_blivet_standard_partition_ext4

1) The associated criterion should be different in my opinion, see this ticket description.
2) With the Create a /boot partition and set the filesystem type to ext3, ext4 or xfs. step, we should probably give a hint how large it should be. Take a look how automatic partitioning makes partition, and then add something like Typically, this partition is around X GB in size.
3) We no longer default to having a swap partition, so the step Create an appropriately-sized swap partition should be removed, I believe.

Once this is fixed, I believe the testcases are good to go. Please add the testcases to the Installation matrix template (link to this ticket in the save description) with a proper milestone. Then do the usual dance of linking these testcases in the associated criterion "References" footnote. Thanks!

https://fedoraproject.org/wiki/QA:Testcase_partitioning_custom_lvm_ext4

The steps are fine. But why is "LVM ext4" an invalid link, in the description? I assume it's a mistake. Just use an italics or bold font. I also wouldn't add the new and empty LVM category, but I don't care, as long as the important ones are there :)

https://fedoraproject.org/wiki/QA:Testcase_partitioning_blivet_lvm_ext4

1) The same thing about a broken link in description.
2) Create an ext4 /boot partition. So, you include ext4, lvmthin testcase includes ext4 or xfs, and Sumantro's testcases include ext3, ext4 or xfs. We might want to consolidate it a bit :-) I'd keep ext4 and xfs, because both are default values in certain editions (Workstation, Server). I'd drop ext3, because who cares. Ping @sumantrom, please make the same change, thanks.
3) In the step above, please also include the typical size, please see my review for Sumantro.
4) Create an appropriately-sized swap partition. should be dropped, same as in Sumantro's review.
5) The rest of the testcase asks the user to create standard partitions, but should ask for LVM! This testcase is to cover LVM. It needs to be rewritten. You can take your inspiration e.g. from https://fedoraproject.org/wiki/QA:Testcase_partitioning_blivet_lvmthin .
6) Why is there an empty Ext4 category? I don't see much sense here.

@kparal I have addressed your comments and I will be happy if you can have a look and before I update the current matrices.

@kparal I have addressed your comments and I will be happy if you can have a look and before I update the current matrices.

@sumantrom I made a teeny-tiny change to them and I think we're done. Can you please add them to the installation matrix template? Thanks!

@coremodule Can you please finish the remaining two which you were working on?

@sumantrom I see you already added them to the Installation matrix, I moved them to a better place and fixed one milestone:
https://fedoraproject.org/w/index.php?title=Template%3AInstallation_test_matrix&type=revision&diff=590533&oldid=590530
It's good to put a ticket link into the summary, so that we can trace the changes to the origin, if needed.

The first 2 testcases are now done, thanks @sumantrom, now we just need the other 2 to complete the ticket.

Ping @coremodule

@kparal, see the changes to the above testcases. If you feel they're satisfactory, I will merge them.

2) Create an ext4 /boot partition. So, you include ext4, lvmthin testcase includes ext4 or xfs, and Sumantro's testcases include ext3, ext4 or xfs. We might want to consolidate it a bit :-) I'd keep ext4 and xfs, because both are default values in certain editions (Workstation, Server). I'd drop ext3, because who cares.

I made the changes you asked for regarding dropping specifically mentioning ext3 and adding xfs, however I wonder why we mention xfs at all, when this testcase is focused around using the ext4 filesystem?

@kparal, see the changes to the above testcases. If you feel they're satisfactory, I will merge them.

I made a few changes and the testcases are now live:
https://fedoraproject.org/wiki/Template:Installation_test_matrix#Custom_storage_configuration

I made the changes you asked for regarding dropping specifically mentioning ext3 and adding xfs, however I wonder why we mention xfs at all, when this testcase is focused around using the ext4 filesystem?

Honestly, I don't have a strong opinion whether to mandate ext4 just for the root partition or all partitions. All the testcases called Testcase_partitioning_*_standard_partition_* asked for just the root partition and allowed other choices for other partitions, and also their description said their purpose is to check the root partition functionality. So I just wanted to follow suit. But for your LVM testcases, I noticed their description was formulated differently, and you might be right, it could be confusing to just set the root partition, because then it seems to contradict the description. So in the end I asked for all partitions to be ext4 in your testcases. I might think about how to make all the testcases consistent in the future.

This ticket is now resolved :beers: