= bug description =
When bugzilla faults during proposal don't have fault code 51, the internal !BugzillaError class isn't used and the fault is lost when attempting to extract information from it
{{{ [Wed Mar 27 13:26:38 2013] [error] [20130327-13:26PM] [blockerbugs] [ERROR] Exception on /propose_bug [POST] [Wed Mar 27 13:26:38 2013] [error] Traceback (most recent call last): [Wed Mar 27 13:26:38 2013] [error] File "/usr/lib/python2.6/site-packages/flask/app.py", line 1687, in wsgi_app [Wed Mar 27 13:26:38 2013] [error] response = self.full_dispatch_request() [Wed Mar 27 13:26:38 2013] [error] File "/usr/lib/python2.6/site-packages/flask/app.py", line 1360, in full_dispatch_request [Wed Mar 27 13:26:38 2013] [error] rv = self.handle_user_exception(e) [Wed Mar 27 13:26:38 2013] [error] File "/usr/lib/python2.6/site-packages/flask/app.py", line 1358, in full_dispatch_request [Wed Mar 27 13:26:38 2013] [error] rv = self.dispatch_request() [Wed Mar 27 13:26:38 2013] [error] File "/usr/lib/python2.6/site-packages/flask/app.py", line 1344, in dispatch_request [Wed Mar 27 13:26:38 2013] [error] return self.view_functionsrule.endpoint [Wed Mar 27 13:26:38 2013] [error] File "/usr/lib/python2.6/site-packages/blockerbugs/controllers/users.py", line 84, in decorated_function [Wed Mar 27 13:26:38 2013] [error] return f(args, *kwargs) [Wed Mar 27 13:26:38 2013] [error] File "/usr/lib/python2.6/site-packages/blockerbugs/controllers/main.py", line 375, in propose_bug [Wed Mar 27 13:26:38 2013] [error] bugform.bugid.errors = [e.msg] [Wed Mar 27 13:26:38 2013] [error] AttributeError: 'Fault' object has no attribute 'msg' }}}
= fix recommendation =
Either all of the bugzilla faults need to be wrapped in a !BugzillaError or the error handling needs to be capable of handling multiple error types.
Fixed in [https://git.fedorahosted.org/cgit/blockerbugs.git/commit/?h=develop&id=0b8ea6d6ef2e3bddc64aeea7c2afe2a1d9034da3 0b8ea6d6ef2e3bddc64aeea7c2afe2a1d9034da3]
Log in to comment on this ticket.