#327 test cases that require autopart shrink need to be updated
Closed: Invalid None Opened 11 years ago by kparal.

Anaconda removed shrink option from guided part, now you need to do custom part to achieve it. The test cases must be adjusted to reflect that. See https://bugzilla.redhat.com/show_bug.cgi?id=891881


Note this is a temporary change for F18, I believe it's planned to come back in F19. So we may want to go with admon boxes or something, not permanent changes.

Oh, and the dualboot_with_windows test case really shouldn't include using Anaconda shrink at all, as it's actually not intended to cover the shrink function. It should be modified so that you start the test case with a Windows install and some free space, I believe.

Replying to [comment:2 adamwill]:

Note this is a temporary change for F18, I believe it's planned to come back in F19. So we may want to go with admon boxes or something, not permanent changes.

Temporary changes tend to become permanent :-) Let's adjust again when/if anaconda changes.

Replying to [comment:3 adamwill]:

Oh, and the dualboot_with_windows test case really shouldn't include using Anaconda shrink at all, as it's actually not intended to cover the shrink function. It should be modified so that you start the test case with a Windows install and some free space, I believe.

Even though I personally don't feel great about this approach, it was part of the changes I made in that test case. I plan to start discussion about it later.

kparal: it's very unlikely to become permanent. The whole newUI design expects shrink to be available in 'guided partitioning'. removing it for f18 final was an ugly hack to deal with https://bugzilla.redhat.com/show_bug.cgi?id=875944 . I don't believe anaconda team considers it acceptable that shrink is only possible via custom, but it was not practical to fix this properly for f18 in the time available.

From F19 onwards shrink was back in guided partitioning, so we don't need to change anything any more; the relevant test cases have all been poked since then anyway, I think.

Login to comment on this ticket.

Metadata