PR#9: Update README.md - fedora-qa/fedora-gooey-karma

fedora-qa / fedora-gooey-karma

#9 Update README.md

Closed 4 years ago by thisisshub. Opened 4 years ago by thisisshub.

Unknown source master into master

Update README.md

Shubhashish Dixit • 4 years ago

16d88d2

README.md

file modified

+7 -47

		`@@ -1,65 +1,25 @@`
		`- THIS PROJECT IS NOW UNMAINTAINED.`
		`-`
		`- This project has been broken with the switch from Bodhi1 to Bodhi2, and nobody`
		`- found the time to fix it since. If somebody wants to fix the project and`
		`- start maintaining it, you're very welcome, please submit a pull request.`
		`-`
		`- ----`
		`-`
		`# Fedora Gooey Karma`

		`fedora-gooey-karma provides similar functionality to the fedora-easy-karma via GUI. It also currently provides some extra info like: dnf info, bodhi info, test cases, bugs.`

		`- Based on http://tirfa.com/gooey-karma.html`
		`+ https://fedoraproject.org/wiki/Fedora_Gooey_Karma`


		`## Dependencies`
		`+ PySide2`
		`+ PyQt5`

		`- python-fedora`
		`- fedora-cert`
		`- dnf`
		`- bodhi-client`
lruzicka commented 4 years ago Are you sure, that the application will work without bodhi-client?
		`- python-pyside`
		`- python-keyring`
		`- koji`
		`- PyQt4`
		`-`
		`- To install these dependencies, use this command:`

		`- dnf install python-fedora fedora-cert bodhi-client python-pyside python-keyring koji PyQt4`
		`-`
		`- ## Installation and usage`
		`+ ## usage`

		`### Clone the repo`

		`- git clone https://pagure.io/fedora-qa/fedora-gooey-karma.git`
		`- cd fedora-gooey-karma`
		`+ git clone https://pagure.io/forks/imzubin/fedora-qa/fedora-gooey-karma.git`
		`+ cd fedora-gooey-karma/src`

		`### Run the application`

		`- The easiest way to run application is to type:`
		`-`
		`- make run`
		`-`
		`- You can also run the script without Makefile:`
		`-`
		`- ./src/fedora-gooey-karma`
		`-`
		`- ### Installation to filesystem`
		`-`
		`- If you decide to install application to filesystem, use install phase from Makefile:`
		`-`
		`- make install`
		`-`
		`- ### Building rpm package on Fedora`
		`-`
		- You are able to build your own RPM package on Fedora using `fedora-package/build_rpm.sh` script in the `tools` branch. Please review this script before to adjust paths of rpmbuild and so.
		`-`
		`- ## Authors`
		`-`
		`- Branislav Blaskovic <branislav@blaskovic.sk>`
lruzicka commented 4 years ago Hello, why did you delete the original authors? I have seen that this application still uses pieces of old code, so to delete their names is not fair. Please, add your name to the list and leave the original authors there.
		`- Tomas Meszaros <exo@tty.sk>`
		`- Dominika Regeciova <regeciovad@gmail.com>`
		`+ ./FedoraGooeyKarma`

		`## Contact`

thisisshub commented 4 years ago

used @imzubin fork for reference of files and necessary changes

lruzicka commented on line 67 of README.md 4 years ago

Hello, why did you delete the original authors? I have seen that this application still uses pieces of old code, so to delete their names is not fair.
Please, add your name to the list and leave the original authors there.

lruzicka commented on line 25 of README.md 4 years ago

Are you sure, that the application will work without bodhi-client?

lbrabec commented 4 years ago

Why is this a separate pull request? Changes in REAMDE.md don't make any sense without accompanying changes in code. Let's have discussion in PR #8 (there are already comments from @frantisekz regarding README.md)

kparal commented 4 years ago

I've granted both of you (@imzubin @thisisshub) commit rights to this this project. Please create a new branch (called e.g. gsoc or rework) and publish all your changes in there together. Create a pull request from that branch, and we can have a discussion on that. Anyone will be able to update the code at any time.