Hi,

I didn't look at the code yet, but please, remove .vscode directory from the PR, there is no need to have it in the repository.

Also, you can leave COPYING and AUTHORS file in place for now.

okay,
The code isn't perfect yet, but the project is at least working right now.
I'll be working on this for a while.
oh yeah, I'll add ".vscode" to gitignore
and add back the COPYING and AUTHORS files.

And... it doesn't seem to work at all, I can't type anything into the app.

https://i.imgur.com/3gPDLD3.png

Reproduced on F31 and F30 (by @lbrabec).

Also, can you provide list of packages needed to run the app? I was able to do it after some googling, but it should be in the readme file.

ohh yeah, I'll do that.
and will look into the issue

On Tue, Aug 27, 2019 at 6:55 PM Franti=C5=A1ek Zatloukal pagure@pagure.io
wrote:

frantisekz commented on the pull-request: python2 to python3 port that
you are following:
``
And... it doesn't seem to work at all, I can't type anything into the app=
.

https://i.imgur.com/3gPDLD3.png

Reproduced on F31 and F30 (by @lbrabec).

Also, can you provide list of packages needed to run the app? I was able
to do it after some googling, but it should be in the readme file.
``

To reply, visit the link below or just reply to this email
https://pagure.io/fedora-qa/fedora-gooey-karma/pull-request/8

@frantisekz this project works just fine. Author has just not yet enabled multi-threading I guess, which i suppose he will.

@frantisekz this project works just fine. Author has just not yet enabled multi-threading I guess, which i suppose he will.

This has nothing to do with multi-threading. It is broken on GNOME Xorg Session and works on Wayland. I've tried it in clean F31 VM right now.

It is really important that i runs also in Xorg sessions.

You need also python3-bodhi-client to run it

I'd prefer to use fedora package names, so python3-qt5 instead of PyQt5 , and it needs also python3-pyside2. You can leave pip package names in requirements.txt

What is the purpose of having both src/fedora-gooey-karma and src/FedoraGooeyKarma?

They seem almost identical:

$ diff src/fedora-gooey-karma src/FedoraGooeyKarma
29a30
> 
141c142,143
<                 try: 
---
>                 try:
>                         print("fetching")
213c215
<                                         response = self.comment(t, self.ui.commentEdit.toPlainText(), self.ui.karmaBox.currentText(),self.ui.critpathBox.currentText())
---
>                                         self.comment(t, self.ui.commentEdit.toPlainText(), self.ui.karmaBox.currentText(),self.ui.critpathBox.currentText())
216c218
<                                 response = self.comment(t, self.ui.commentEdit.toPlainText(), self.ui.karmaBox.currentText())
---
>                                 self.comment(t, self.ui.commentEdit.toPlainText(), self.ui.karmaBox.currentText())

What is the point of using both PyQt5 and Pyside2? Pick one and use only that. Some differences are described here: https://www.learnpyqt.com/blog/pyqt5-vs-pyside2/

Also, as you are importing it directly, both pyside2 and pyqt5, only one will end up being used:

from PySide2 import QtCore, QtGui, QtWidgets
from PyQt5 import QtCore, QtGui, QtWidgets

@frantisekz Yes, I realised most of the things you commented here.
I've been looking for the Xorg fix right now, for now, I'll close this PR and get back to this repo once I fix the bugs.

about using the fedora packages instead of python ones,
the fedora packages are somewhat broken or Idk what's up with that if I run the program on them, It doesn't work, so I'll have to stick with python packages for now.

also, thanks for testing it properly. much appreciated.

Sure, take your time :)

(Regarding the Fedora packages, if this tool is to be packaged in Fedora, it has to use Fedora packages, not those from pip. I did all the testing with Fedora (F31) packages and it worked well on Wayland session.)