602d074 switch from virt-builder to virt-install (T813)

Authored and Committed by adamwill 7 years ago
    switch from virt-builder to virt-install (T813)
    
    Summary:
    We've kinda been having too much trouble with virt-builder
    lately, mainly SELinux related issues due to how it does image
    customization. It also produces images that differ in notable
    ways from what a 'typical' install would give. virt-install
    solves both these problems, and also gives us more flexibility
    for storage configuration and post-install customization should
    we need them in future.
    
    The change isn't really too drastic, and the design is similar:
    instead of virt-builder commands files, each image type now has
    a kickstart file where all its customizations can be done.
    There's also a single extra image dict key, 'variant', which
    specifies which install tree variant to use for running the
    install. It defaults to 'Everything' (for F24+) and 'Server'
    (for 
    set it to 'Server' for the server images and 'Workstation' for
    the desktop images, so those installs will use the correct
    variant install class.
    
    We run the installs in VNC. You can do it with a serial console
    and log the output, but then anaconda gets clever and changes
    several things in the installed system based on the fact that
    you did the install over a serial console: it twiddles with
    the kernel args and doesn't set graphical.target as the default.
    We don't want any of that mess, so we do a VNC install.
    
    The 'size' value is just a number of gigabytes for virt-install
    images (as that's how the virt-install 'size' argument works).
    
    This also drops some unused 32-bit images (we don't do 32-bit
    KDE or Server upgrade tests, so there's no need to build those
    images).
    
    Test Plan:
    Re-generate all affected images and re-run all tests
    that use them, make sure they work. I am doing this on staging
    at present. Note: this would render D911 unnecessary.
    
    Reviewers: garretraziel
    
    Reviewed By: garretraziel
    
    Subscribers: tflink
    
    Differential Revision: https://phab.qadevel.cloud.fedoraproject.org/D917
    
        
file modified
+92 -62
file removed
-11
file added
+17
file modified
+19 -13
file removed
-14
file added
+20
file removed
-3
file added
+16
file removed
-6
file added
+17
file removed
-4
file added
+19