PR#91: Don't try and add null bug milestone to update milestones - fedora-qa/blockerbugs

fedora-qa / blockerbugs

#91 Don't try and add null bug milestone to update milestones

Merged 4 years ago by adamwill. Opened 4 years ago by adamwill.

fedora-qa/ adamwill/blockerbugs no-none-milestone into develop

Don't try and add null bug milestone to update milestones

Adam Williamson • 4 years ago

1ca7762

blockerbugs/models/update.py

file modified

+1 -1

		`@@ -100,7 +100,7 @@`
		`for bug in newbugs:`
		`if not bugid in current_bugids:`
		`self.bugs.append(bug)`
		`- if not bug.milestone in self.milestones:`
		`+ if bug.milestone and not bug.milestone in self.milestones:`
		`self.milestones.append(bug.milestone)`

		`@classmethod`

adamwill commented 4 years ago

I'm not sure how, but on my local dev instance I got into a
situation where we hit this block for a bug that didn't have a
milestone, so we tried to put None into self.milestones here.
That causes sqalchemy to blow up. So, let's protect against
that just in case it somehow happens to the production instance
later...

Signed-off-by: Adam Williamson awilliam@redhat.com