#181 blocker_list: don't display update popup needlessly
Merged 2 years ago by kparal. Opened 2 years ago by kparal.

@@ -107,12 +107,17 @@ 

                                  TBD

                              {% endif %}

                          </td>

-                         <td class="popupification">

-                             <a href="{{ url_for('main.display_bug_updates', bugid=bug.bugid) }}"

-                                 rel="{{ url_for('main.display_bug_updates', bugid=bug.bugid) }}"

-                                 title='{{ bug.bugid }}'>

-                                 {{ bug | updatelabel | safe}}</a>

-                         </td>

+                         {% set update_html = bug | updatelabel | safe %}

+                         {% if update_html %}

+                             <td class="popupification">

+                                 <a href="{{ url_for('main.display_bug_updates', bugid=bug.bugid) }}"

+                                     rel="{{ url_for('main.display_bug_updates', bugid=bug.bugid) }}"

+                                     title='{{ bug.bugid }}'>

+                                     {{ update_html }}</a>

+                             </td>

+                         {% else %}

+                             <td />

+                         {% endif %}

                      </tr>

                  {% else %}

                      <tr>

The update popup was quite annoying, because it displayed over every row, even
when there was no update present for that bug. With this change, the popup only
shows on rows where there is some update available.

Metadata Update from @kparal:
- Request assigned

2 years ago

Build succeeded.

Hey @lbrabec, do you have time to review this? Thanks.

Commit 6a7ac8d fixes this pull-request

Pull-Request has been merged by kparal

2 years ago
Metadata