fedora-qa / blockerbugs

Clone
Source Code
GIT

#131 blocker_list: rename Vote to Discuss
Merged 3 years ago by kparal. Opened 3 years ago by kparal.
reword-vote  into  develop

file modified
+1 -1 
@@ -77,7 +77,7 @@ 
 

                          <td>{{ bug.component }}</td>
 

                          <td>{{ bug.status }}</td>
 

                          <td>{{ bug.summary }}</td>
 

-                         <td><a href='{{ bug.discussion_link }}' target="_blank" rel="noopener noreferrer">Vote</a></td>
 

+                         <td><a href='{{ bug.discussion_link }}' target="_blank" rel="noopener noreferrer">{{ 'Discuss' if buglist.startswith('Accepted') else 'Vote!' }}</a></td>
 

                          <td class="popupification">
 

                              <a href="{{ url_for('main.display_bug_updates', bugid=bug.bugid) }}"
 

                                  rel="{{ url_for('main.display_bug_updates', bugid=bug.bugid) }}"

Adam had a point that it's slightly confusing that even accepted blockers have
a 'Vote' link displayed. Let's change it to 'Discuss' which is generic and can
be used for both proposed and accepted.

Honestly, I know it's a little more work, but I'd kinda like to use different words for the different tables...I do like it being a clear "Vote here!" thing for the proposed ones. "Discuss" doesn't really hint that very well.

I agree with Adam, that the messages should be different. While we'd like to encourage the visitors to actually vote for the proposed bugs and not just discuss them..
With accepted blockers, there is no need to vote for them any more, so the message should be different. Discuss is one option. Also Comment, Provide more info, or anything similar may be used.

rebased onto c9dc164
3 years ago

It was easier than expected. Thank you @lruzicka for actually providing some words to choose from :) What about this?
/me trying to attach an image into pagure comment box, seems impossible
https://i.imgur.com/m4RZnQq.png

Seems great Kamil!

The one nitpick that comes to mind is having an exclamation mark near "vote" and not near "discuss". I understand that Vote! is more like call to action, but I'd prefer a little bit having it without exclamation mark ?

Well Adam wanted Vote here!. So agree on something, guys :) I personally like the exclamation mark for proposed trackers, we want to call into action as many contributors as we can. But I don't really care, just agree on something.

I give up, lgtm Kamil!

This is definitely better than before. However, I also wanted to nitpick the same way as @frantisekz did. If we accepted Adam's proposal to Vote here! then Discuss here! would be appropriate. Also, these lines look like a full sentence to me, so the exclamation marks seems just.

When using Vote! (and we still want to keep that exclamation mark for urgency), perhaps we could use Discuss. with a full stop, to make it also sound a full sentence. However, it does not look much better when I think about it more.

So I guess, we can go with the current solution. Thanks, Kamil.

You know what? I'll just push it, and you can bikeshed here as much as you like, and after 3 long months of fierce discussion you can tell me the result and I'll adjust it, OK? :-)

Commit 15d54a9 fixes this pull-request

Pull-Request has been merged by kparal
3 years ago

I believe we should let @adamwill to have his say ... he is a well-studied native speaker, so he might have some feelings we cannot spot. :D Anyway, @kparal , we will let you know when there is the anniversary next summer.
Metadata
None
No Tags
Changes Summary 1
+1 -1
file changed
blockerbugs/templates/blocker_list.html
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.