PR#125: Fix WTForms deprecations and make it work with future WTForms 3.0 - fedora-qa/blockerbugs

František Zatloukal • 4 years ago

da2967d

blockerbugs/controllers/admin/build.py

file modified

+1 -1

		`@@ -43,7 +43,7 @@`


		`class BuildForm(flask_wtf.FlaskForm):`
		`- nvr = ReadOnlyTextField('NVR', [wtforms.validators.required()])`
		`+ nvr = ReadOnlyTextField('NVR', [wtforms.validators.data_required()])`

		`class BuildView(FasAuthModelView):`
		`column_searchable_list = (Build.nvr, )`

blockerbugs/controllers/forms.py

file modified

+7 -7

		`@@ -24,7 +24,7 @@`
		`from flask_wtf import Form`
		`from wtforms import TextField, SelectField, BooleanField, IntegerField`
		`from wtforms import TextAreaField, PasswordField, ValidationError`
		`- from wtforms.validators import Required, Email`
		`+ from wtforms.validators import DataRequired, Email`


		`def one_proposal(form, field):`
		`@@ -33,14 +33,14 @@`


		`class BugProposeForm(Form):`
		`- bugid = IntegerField(u'Bug ID', [Required()])`
		`- bz_user = TextField(u'Bugzilla Login', [Required(), Email()])`
		`- milestone = SelectField(u'Milestone', [Required()], coerce=int)`
		`+ bugid = IntegerField(u'Bug ID', [DataRequired()])`
		`+ bz_user = TextField(u'Bugzilla Login', [DataRequired(), Email()])`
		`+ milestone = SelectField(u'Milestone', [DataRequired()], coerce=int)`
		`blocker = BooleanField(u'Blocker', [one_proposal])`
		`freeze_exception = BooleanField(u'Freeze Exception', [one_proposal])`
		`- justification = TextAreaField(u'Justification', [Required()])`
		`+ justification = TextAreaField(u'Justification', [DataRequired()])`


		`class FasBugzillaForm(Form):`
		`- bz_user = TextField(u'Login', [Required(), Email()])`
		`- bz_pass = PasswordField(u'Password', [Required()])`
		`+ bz_user = TextField(u'Login', [DataRequired(), Email()])`
		`+ bz_pass = PasswordField(u'Password', [DataRequired()])`

requirements.txt

file modified

+1 -1

		`@@ -1,7 +1,6 @@`
		`# the flask and werkzeug freeze is to reflect the state on production`
		`Flask == 1.1.1`
		`Werkzeug == 0.16.0`
		`- WTForms < 3.0 # Known to be broken with master/3.0`

		`alembic`
		`bodhi-client`
		`@@ -25,3 +24,4 @@`
		`python-openid-teams`
		`python3-openid`
		`SQLAlchemy`
		`+ WTForms`