PR#100: Admin: Use Bootstrap 3 - fedora-qa/blockerbugs

fedora-qa / blockerbugs

#100 Admin: Use Bootstrap 3

Merged 5 years ago by frantisekz. Opened 5 years ago by frantisekz.

admin_bs3 into develop

František Zatloukal • 5 years ago

27b34c1

blockerbugs/controllers/admin/__init__.py

file modified

		`@@ -42,6 +42,7 @@`

		`admin = flask_admin.Admin(app, 'Blocker Bug Tracking Admin',`
		`base_template='admin_layout.html',`
		`+ template_mode='bootstrap3',`
		`index_view=AdminIndexViewSqla())`

blockerbugs/static/css/admin_layout.css

file modified

-5

		`@@ -1,8 +1,3 @@`
		`- /* line 1, ../../../sass/admin_layout.scss */`
		`- input {`
		`- width: 530px;`
		`- }`
		`-`
		`/* line 5, ../../../sass/admin_layout.scss */`
		`.select2-container {`
		`width: 545px !important;`

sass/admin_layout.scss

file modified

-4

		`@@ -1,7 +1,3 @@`
		`- input {`
		`- width: 530px;`
		`- }`
		`-`
		`.select2-container {`
		`width: 545px !important;`
		`}`
		`\ No newline at end of file`

no initial comment

rebased onto 27b34c1

5 years ago

jskladan commented 5 years ago

I know this is probably out of context for the PR, but looking at the template for the admin interface https://pagure.io/fedora-qa/blockerbugs/blob/develop/f/blockerbugs/templates/admin_layout.html it {% extends 'admin/base.html' %}, but there is no admin/base.html file in the repo. That looks wrong :)

frantisekz commented 5 years ago

That html file is part of python3-flask-admin, so I guess it uses it from there.

$ rpm -ql python3-flask-admin | grep base.html
/usr/lib/python3.7/site-packages/flask_admin/templates/bootstrap2/admin/base.html
/usr/lib/python3.7/site-packages/flask_admin/templates/bootstrap3/admin/base.html
....

Edited 5 years ago by frantisekz

jskladan commented 5 years ago

ah, makes sense. Thanks for the clarification.

LGTM!

Pull-Request has been merged by frantisekz

5 years ago