#153 discussions: be more permissive in voting commands syntax
Closed: Fixed 4 months ago by kparal. Opened 5 months ago by kparal.

In blockerbugs discussion tickets feedback it was mentioned that the current TRACKER VOTE command syntax is too strict and people are having troubles type it correctly every time (ticket #152 is related to this).

@adamwill said:

I would kind of like if the parsing was more permissive. I'd at least expect it to accept any combination in any order of "+1/-1", a valid vote target name, and any amount of whitespace as a valid vote.

I guess it shouldn't be a problem for us to accept all of these:

BetaBlocker +1
BetaBlocker     +1
BetaBlocker +1␠␠
  BetaBlocker +1
+1 BetaBlocker
+1    BetaBlocker
+1 BetaBlocker␠␠
  +1 BetaBlocker

(where shows a trailing whitespace)

Thoughts?


Issue tagged with: next

5 months ago

Metadata Update from @lbrabec:
- Issue assigned to lbrabec

5 months ago

yup, that's exactly what I was thinking. Thanks.

@lbrabec already has some work-in-progress implementation for this

Sigh, Pagure. We do have the PRs already, in #160 and #161.

Login to comment on this ticket.

Metadata
Boards 1
Next tasks Status: Done
Related Pull Requests
  • #163 Merged 4 months ago
  • #161 Merged 4 months ago
  • #160 Merged 4 months ago