From b01fea8461a5cb0a1d3612747d28fb5555ba9348 Mon Sep 17 00:00:00 2001
From: Kamil Páral <kparal@redhat.com>
Date: Jun 07 2021 12:01:35 +0000
Subject: bugzilla: disable "quick" sync in favor of a full sync


The standard "quick" sync takes one or two orders of magnitude longer than a
full sync, and often times out. It seems that while the timestamp optimizations
were helpful with older Bugzilla versions, with Bugzilla5 they are taking
extremely long to evaluate. It seems much better to always do a "full" sync
instead.

If we don't see any negative consequences, let's remove the quick sync code
completely.

Merges: https://pagure.io/fedora-qa/blockerbugs/pull-request/183
Related: https://pagure.io/fedora-qa/blockerbugs/issue/184

---

diff --git a/blockerbugs/cli.py b/blockerbugs/cli.py
index 9b8236e..024c195 100644
--- a/blockerbugs/cli.py
+++ b/blockerbugs/cli.py
@@ -173,8 +173,15 @@ def check_blockers(bzurl):
 
 
 def sync_bugs(args):
-    fullsync = args.full
     docheck = args.check
+    fullsync = args.full
+    # FIXME: as a workaround for very slow standard sync times, perform a full
+    # sync always. If no downsides are found, completely remove the "--full"
+    # cmdline option (and related function arguments) and make full sync the
+    # only approach.
+    # Related: https://pagure.io/fedora-qa/blockerbugs/issue/184
+    fullsync = True
+
 
     # grab the URL from app config so that it's syncing from the right place
     bzurl = app.config['BUGZILLA_XMLRPC']
@@ -271,7 +278,7 @@ def main():
                                         help='Synchronize all')
     sync_parser.add_argument('-f', '--full',
                              action='store_true', default=False,
-                             help='Force full sync')
+                             help='Force full sync (ignored temporarily)')
     sync_parser.add_argument('-c', '--check',
                              action='store_true', default=False,
                              help='Force check for missing blocker bugs after sync')
@@ -281,7 +288,7 @@ def main():
                                              help='Synchronize bugs only')
     sync_bugs_parser.add_argument('-f', '--full',
                                   action='store_true', default=False,
-                                  help='Force full sync')
+                                  help='Force full sync (ignored temporarily)')
     sync_bugs_parser.add_argument('-c', '--check',
                                   action='store_true', default=False,
                                   help='Force check for missing blocker bugs after sync')
diff --git a/blockerbugs/util/bz_interface.py b/blockerbugs/util/bz_interface.py
index a821631..04eb730 100644
--- a/blockerbugs/util/bz_interface.py
+++ b/blockerbugs/util/bz_interface.py
@@ -83,6 +83,9 @@ class BlockerBugs():
             # keep in mind that OP -> open parenthesis, CP -> closed parenthesis
             # and the OR is to make sure that a bug is returned if ANY of the
             # changed after conditions are met
+
+            # FIXME: This seems to be tremendously slowing down Bugzilla5
+            # Related: https://pagure.io/fedora-qa/blockerbugs/issue/184
             query.update({
                 'f2': 'OP',
                 'j2': 'OR',