From 6a7ac8d2d8aa7bdaad457b8d9b91c530a18f5629 Mon Sep 17 00:00:00 2001
From: Kamil Páral <kparal@redhat.com>
Date: May 14 2021 11:52:17 +0000
Subject: blocker_list: don't display update popup needlessly


The update popup was quite annoying, because it displayed over every row, even
when there was no update present for that bug. With this change, the popup only
shows on rows where there is some update available.

Merges: https://pagure.io/fedora-qa/blockerbugs/pull-request/181

---

diff --git a/blockerbugs/templates/blocker_list.html b/blockerbugs/templates/blocker_list.html
index 23ec2d7..3726060 100644
--- a/blockerbugs/templates/blocker_list.html
+++ b/blockerbugs/templates/blocker_list.html
@@ -107,12 +107,17 @@ text: '<a href="' + $(this).contents().filter('a').attr('href') + '" title="More
                                 TBD
                             {% endif %}
                         </td>
-                        <td class="popupification">
-                            <a href="{{ url_for('main.display_bug_updates', bugid=bug.bugid) }}"
-                                rel="{{ url_for('main.display_bug_updates', bugid=bug.bugid) }}"
-                                title='{{ bug.bugid }}'>
-                                {{ bug | updatelabel | safe}}</a>
-                        </td>
+                        {% set update_html = bug | updatelabel | safe %}
+                        {% if update_html %}
+                            <td class="popupification">
+                                <a href="{{ url_for('main.display_bug_updates', bugid=bug.bugid) }}"
+                                    rel="{{ url_for('main.display_bug_updates', bugid=bug.bugid) }}"
+                                    title='{{ bug.bugid }}'>
+                                    {{ update_html }}</a>
+                            </td>
+                        {% else %}
+                            <td />
+                        {% endif %}
                     </tr>
                 {% else %}
                     <tr>