I'm at least:
FinalFE +1
to this, blocker call is borderline for me (both whether to accept and whether to waive if so).

FinalFE +1

I'm also
FInalBlocker +1

I think this is a pretty clear blocker since it can't really be fixed post-release if the machine doesn't actually have network access and the default mode of operation is to not use networked repos if you're using the DVD iso. It is an easy workaround to just enable networked repos which would work for most installs but that does defeat some of the purpose of publishing the DVD.

That being said, I'm probably +1 on waiving this if we can't get a 1.5 together in time. While it is a blocker, I'm not convinced it's worth slipping over.

FinalFE +1
FInalBlocker +1

For the reasons Tim argued. But me too, I think this is something we probably can waive tomorrow.

FinalFE +1
FinalBlocker +1

FinalBlocker -1

because of https://bugzilla.redhat.com/show_bug.cgi?id=2186358#c6

because of https://bugzilla.redhat.com/show_bug.cgi?id=2186358#c6

RC 1.5 includes a fix for this. Either we close the bug and then there's no reason to vote, or we continue voting on the problem, in case we want to release 1.4 (because 1.5 isn't tested properly, for example). Either way, please don't give it -1 on the grounds that it has been fixed over night, that doesn't make sense. Thanks.

because of https://bugzilla.redhat.com/show_bug.cgi?id=2186358#c6

RC 1.5 includes a fix for this. Either we close the bug and then there's no reason to vote, or we continue voting on the problem, in case we want to release 1.4 (because 1.5 isn't tested properly, for example). Either way, please don't give it -1 on the grounds that it has been fixed over night, that doesn't make sense. Thanks.

Got it, agreed. Thanks for explanation.

Based on that:

FinalBlocker +1
FinalFE +1

FinalBlocker +1

because there's likely a scenario where this fails (a non-interactive install) and can't be easily worked around. An incomplete DVD fails these two criteria:
https://fedoraproject.org/wiki/Basic_Release_Criteria#dvd-package-source
https://fedoraproject.org/wiki/Basic_Release_Criteria#Media_package_source

I'm not as certain that a kickstart install would fail, or that this violates either criterion. A kickstart install may well just prompt for input in the same way, rather than failing. It should at least be tested.

The criterion says the installer must be able to use the DVD as a package source, and it is. It's not clear to me how "a package that we try to pull in in some circumstances is not on the DVD" constitutes a violation of that criterion.

(because 1.5 isn't tested properly, for example).

Uff.. The only difference between 1.4 and 1.5 is this: https://pagure.io/fedora-comps/pull-request/829#request_diff (ref. https://pagure.io/releng/issue/11378#comment-851308 )

Sanity tests for 1.5 were done. I don't have many ideas how more properly could we test the 1.5. Do you have some, @kparal ?

For the record, this was discussed at the go/no-go meeting today and accepted as a blocker.
AGREED AcceptedFinalBlocker

The following votes have been closed:

• Accepted FinalBlocker (+5, 0, -0)
  • +1 by tflink, geraldosimiao, sumantrom, augenauf, kparal

(because 1.5 isn't tested properly, for example).
I don't have many ideas how more properly could we test the 1.5.

That was a hypothetical example situation, not a statement about the current situation. I was describing why it still makes sense to vote on this bug, as present in RC 1.4.

Release F38 is no longer tracked by BlockerBugs, closing this ticket.